Generalize /children endpoints to be usable outside of landing page #3, general rewrite/update #2#6
Merged
Merged
Conversation
2 tasks
This was
linked to
issues
Dec 7, 2025
… general rewrite/update #2
This was referenced Dec 7, 2025
gadomski
requested changes
Dec 9, 2025
gadomski
left a comment
gadomski
left a comment
Member
There was a problem hiding this comment.
Just some minor copy-edits, otherwise makes sense to me.
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
gadomski
approved these changes
Dec 9, 2025
Contributor
|
This PR implements the hierarchical navigation concepts (specifically having /children accessible on any catalog/collection and not just the root) that were the core focus of my previous PR #4 While I understand this is an improved version, it effectively replaces PR #4. To preserve the history of this architectural pattern, could you please add me as a co-author on the merge commit? |
jsignell
approved these changes
Dec 9, 2025
jsignell
left a comment
jsignell
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me as well
Co-authored-by: Julia Signell <jsignell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @jonhealy1
Related Issue(s):
Proposed Changes:
parentrelation typePR Checklist: