Fix flaky TestKeepAlive_ConcurrentFramesNoInterleaving - #220
Open
jhrozek wants to merge 1 commit into
Open
Conversation
The comments>0 assertion raced 1600 in-memory writes against a 1ms ticker and lost deterministically on fast machines. Split it into a separate test that waits for a tick via require.Eventually instead of tightening the timing. Fixes #219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestKeepAlive_ConcurrentFramesNoInterleavingassertedcomments > 0, racing 1600 in-memory writes against a 1ms ticker — on fast machines the writes finish andstopKeepAlive()runs before the ticker ever fires, socommentsis 0.TestKeepAlive_TickerEmitsComment, which waits deterministically viarequire.Eventuallyinstead of assuming a tick happens within a fixed window of work.Fixes #219
Test plan
go test -race -count=10 -run TestKeepAlive ./mcpcompat/server/— all passtask lint