[pull] master from rmosolgo:master

.github/ISSUE_TEMPLATE/bug_report.md

@@ -19,12 +19,11 @@ other applicable versions (`graphql-batch`, etc)
 
 **GraphQL schema**
 
-Include relevant types and fields (in Ruby is best, in GraphQL IDL is ok).
-Are you using [interpreter](https://graphql-ruby.org/queries/interpreter.html)? Any custom instrumentation, etc?
+Include relevant types and fields (in Ruby is best, in GraphQL IDL is ok). Any custom extensions, etc?
 
 ```ruby
 class Product < GraphQL::Schema::Object
-  field :id, ID, null: false, hash_key: :id
+  field :id, ID, hash_key: :id
   # …
 end
 

.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/actions-lint.yaml

@@ -0,0 +1,42 @@
+name: Lint GitHub Actions
+
+on:
+  pull_request:
+  push:
+    branches:
+      - master
+
+permissions: {}
+
+jobs:
+  actionlint:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        with:
+          persist-credentials: false
+      - name: Run actionlint
+        uses: docker://rhysd/actionlint:1.7.12
+        with:
+          args: -color
+
+  zizmor:
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        with:
+          persist-credentials: false
+      - name: Run zizmor
+        uses: zizmorcore/zizmor-action@6fc4b006235f201fdab3722e17240ab420d580e5 # v0.6.1
+        with:
+          advanced-security: false
+          annotations: true
+          min-severity: high
+          version: 1.28.0

.github/workflows/ci.yaml

@@ -1,36 +1,43 @@
 name: CI Suite
 on:
-  - push
   - pull_request
 
 jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1
+    - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+    - uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1.321.0
       with:
-        ruby-version: 2.6
+        ruby-version: 3.4
         bundler-cache: true
     - run: bundle exec rake rubocop
+    - run: npx @herb-tools/linter@0.8.10
   system_tests:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1
+    - uses: shogo82148/actions-setup-redis@3e38d435ea02619c76909c929ecc501806c7145e # v1.56.0
       with:
-        ruby-version: 2.6
+        redis-version: "7.x"
+    - run: redis-cli ping
+    - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+    - uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1.321.0
+      with:
+        ruby-version: 3.4
         bundler-cache: true
       env:
-        BUNDLE_GEMFILE: ./spec/dummy/Gemfile
-    - run: bundle exec rails test:system
+        BUNDLE_GEMS__GRAPHQL__PRO: ${{ secrets.BUNDLE_GEMS__GRAPHQL__PRO }}
+        BUNDLE_GEMFILE: gemfiles/rails_master.gemfile
+    - run: bin/rails test:all
       working-directory: ./spec/dummy
+      env:
+        BUNDLE_GEMS__GRAPHQL__PRO: ${{ secrets.BUNDLE_GEMS__GRAPHQL__PRO }}
+        BUNDLE_GEMFILE: ../../gemfiles/rails_master.gemfile
   # Some coverage goals of these tests:
   # - Test once without Rails at all
   # - Test postgres, to make sure that the ActiveRecord
   #   stuff works on that (as well as the default sqlite)
   # - Test mongoid -- and several versions, since they're quite different
-  # - Run the tests with Rails _and_ TESTING_LEGACY=1 to test legacy codepaths
   # - Run the JS unit tests once
   # - Test each major version of Rails we support
   # - Test the min/max minor Ruby version we support (and others?)
@@ -40,54 +47,65 @@ jobs:
       matrix:
         include:
           - gemfile: Gemfile
-            ruby: 2.6
-          - gemfile: gemfiles/rails_3.2.gemfile
-            ruby: 2.3
-            bundler: "1"
-          - gemfile: gemfiles/rails_4.2.gemfile
-            ruby: 2.4
-            bundler: "1"
-          # Rails 5.2 is tested with Postgresql below
-          - gemfile: gemfiles/rails_6.1.gemfile
-            ruby: 2.7
-          - gemfile: gemfiles/rails_master.gemfile
-            ruby: 3.0
+            ruby: head
+          - gemfile: Gemfile
+            ruby: 2.7 # lowest supported version
+          - gemfile: gemfiles/rails_8.0.gemfile
+            ruby: 3.3
+            graphql_future: 1
+          - gemfile: gemfiles/rails_8.1.gemfile
+            ruby: 4.0
+            graphql_future: 1
+            redis: 1
           - gemfile: gemfiles/rails_master.gemfile
-            ruby: truffleruby-head
+            ruby: 3.4
+            graphql_future: 1
+            isolation_level_fiber: 1
+            redis: 1
     runs-on: ubuntu-latest
     steps:
-    - run: echo BUNDLE_GEMFILE=${{ matrix.gemfile }} > $GITHUB_ENV
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1
+    - run: echo BUNDLE_GEMFILE=${{ matrix.gemfile }} > "$GITHUB_ENV"
+    - run: echo GRAPHQL_FUTURE=1 > "$GITHUB_ENV"
+      if: ${{ !!matrix.graphql_future }}
+    - run: echo ISOLATION_LEVEL_FIBER=1 > "$GITHUB_ENV"
+      if: ${{ !!matrix.isolation_level_fiber }}
+    - uses: shogo82148/actions-setup-redis@3e38d435ea02619c76909c929ecc501806c7145e # v1.56.0
+      with:
+        redis-version: "7.x"
+      if: ${{ !!matrix.redis }}
+    - run: redis-cli ping
+      if: ${{ !!matrix.redis }}
+    - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+    - uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1.321.0
       with:
         ruby-version: ${{ matrix.ruby }}
         bundler-cache: true
-        bundler: ${{ matrix.bundler || 'default' }}
+    - run: bundle exec rake compile
     - run: bundle exec rake test
-  legacy_test:
-    runs-on: ubuntu-latest
-    steps:
-    - run: echo BUNDLE_GEMFILE='gemfiles/rails_6.1.gemfile' > $GITHUB_ENV
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 2.7
-        bundler-cache: true
-    - run: bundle exec rake test TESTING_LEGACY=1
   javascript_test:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1
+    - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+    - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
       with:
-        ruby-version: 2.7
-        bundler-cache: true
-    - run: bundle exec rake js:all
+        node-version: latest
+    - run: npm ci
+      working-directory: ./javascript_client
+    - run: npm test
+      working-directory: ./javascript_client
   postgres_test:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        include:
+        - gemfile: gemfiles/rails_master.gemfile
+          ruby: 3.3
+          isolation_level_fiber: 1
+        - gemfile: gemfiles/rails_7.2_postgresql.gemfile
+          ruby: 3.3
     services:
       postgres:
-        image: postgres:latest
+        image: postgres:18.4@sha256:3a82e1f56c8f0f5616a11103ac3d47e632c3938698946a7ad26da0df1334744a
         env:
           POSTGRES_USER: postgres
           POSTGRES_PASSWORD: postgres
@@ -101,33 +119,36 @@ jobs:
           --health-timeout 5s
           --health-retries 5
     steps:
-    - run: echo BUNDLE_GEMFILE='gemfiles/rails_5.2_postgresql.gemfile' > $GITHUB_ENV
-    - run: echo DATABASE='POSTGRESQL' > $GITHUB_ENV
-    - run: echo PGPASSWORD='postgres' > $GITHUB_ENV
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1
+    - run: echo BUNDLE_GEMFILE='' > "$GITHUB_ENV"
+    - run: echo DATABASE='POSTGRESQL' > "$GITHUB_ENV"
+    - run: echo PGPASSWORD='postgres' > "$GITHUB_ENV"
+    - run: echo GRAPHQL_CPARSER=1 > "$GITHUB_ENV"
+    - run: echo ISOLATION_LEVEL_FIBER=1 > "$GITHUB_ENV"
+      if: ${{ !!matrix.isolation_level_fiber }}
+    - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+    - uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1.321.0
       with:
-        ruby-version: 2.7
+        ruby-version: "3.3"
         bundler-cache: true
-    - run: bundle exec rake test
+    - run: bundle exec rake compile test
   mongodb_test:
     strategy:
       fail-fast: false
       matrix:
         gemfile:
-          - gemfiles/mongoid_6.gemfile
-          - gemfiles/mongoid_7.gemfile
+          - gemfiles/mongoid_9.gemfile
+          - gemfiles/mongoid_8.gemfile
     runs-on: ubuntu-latest
     services:
       mongodb:
-        image: mongo:3.4.23
+        image: mongo:8.2.12@sha256:e0ce8c35124d4a9f9785532d1f268f39e9728ffa1cb38f46fa482436424c4bd3
         ports:
         - 27017:27017
     steps:
-    - run: echo BUNDLE_GEMFILE=${{ matrix.gemfile }} > $GITHUB_ENV
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1
+    - run: echo BUNDLE_GEMFILE=${{ matrix.gemfile }} > "$GITHUB_ENV"
+    - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+    - uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1.321.0
       with:
-        ruby-version: 2.7
+        ruby-version: 3.4
         bundler-cache: true
-    - run: bundle exec rake test
+    - run: bundle exec rake compile test

.github/workflows/pronto.yaml

@@ -0,0 +1,31 @@
+name: Pronto
+on: # zizmor: ignore[dangerous-triggers] Runs trusted base-branch code to report on pull requests.
+  - pull_request_target
+
+permissions: {}
+
+jobs:
+  pronto:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
+    steps:
+      - run: echo BUNDLE_GEMFILE=gemfiles/pronto.gemfile > "$GITHUB_ENV"
+      - name: Checkout code
+        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        with:
+          persist-credentials: false
+          ref: ${{ github.event.pull_request.base.sha }}
+      - run: git fetch --no-tags --prune --unshallow origin +refs/heads/*:refs/remotes/origin/*
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1.321.0
+        with:
+          ruby-version: 3.4
+          bundler-cache: true
+      - name: Run Pronto
+        run: bundle exec pronto run -f github_pr -c "origin/${BASE_REF}"
+        env:
+          BASE_REF: ${{ github.base_ref }}
+          PRONTO_PULL_REQUEST_ID: ${{ github.event.pull_request.number }}
+          PRONTO_GITHUB_ACCESS_TOKEN: "${{ github.token }}"