fix(helpers): render zero weight and backendRef filters in HTTPRoute - #615
Open
aslafy-z wants to merge 1 commit into
Open
fix(helpers): render zero weight and backendRef filters in HTTPRoute#615aslafy-z wants to merge 1 commit into
aslafy-z wants to merge 1 commit into
Conversation
aslafy-z
force-pushed
the
fix/httproute-weight-filters
branch
from
August 19, 2026 14:28
f4ac4e9 to
2ff5861
Compare
aslafy-z
force-pushed
the
fix/httproute-weight-filters
branch
from
August 19, 2026 14:29
2ff5861 to
9691888
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #613. Follow-up to #603, fixing the two defects in the
application.httpRoute.ruleshelper.What changed
weight: 0is now rendered. The renderer guarded weight with a truthiness check ({{- if .weight }}), so an explicitweight: 0was omitted from the manifest. Since the Gateway API defaults an omitted weight to 1, a backend drained withweight: 0kept receiving traffic. The guard is now a presence check, with the same empty-templated-value handling as port.Per-backendRef
filtersare passed through. The backendRef renderer was a field whitelist (name,port,weight,namespace,kind,group), soHTTPBackendRef.filtersvalidated against the schema but never reached the manifest. AtoYamlpassthrough now renders it, matching the existing rule-levelmatches/filters/timeoutshandling.Validation
weight: 0, empty templated weight treated as unset, and per-backendRef filters passthrough.helm lintis clean.helm templaterender:weight: 0and theRequestHeaderModifierfilter now appear on the rendered backendRef.