You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was trying to closely follow patterns in related functions like the binomial_logit_glm_lmpf and categorical_logit_glm_lpmf which this is a generalization of both.
The typing:
observations y are a 2D array [,] int non-negative (rows=instances, columns=outcome classes)
thus the predictors x are matrix(rows=instances, columns=features)
the coefficients beta are a matrix (rows=features, columns=outcome classes)
then the intercept alpha may be either a matrix (same shape as y) or a row_vector (length=outcome classes). Now this may seem a little irregular at first, but it makes sense when you really think about it. Other GLMs offer either a vector or real for the intercept. In the multivariate case, the (univariate) vector corresponds to the matrix and the scalar to be copied for each instance is more naturally represented here as a row_vector rather than a column. (It can be seen as an extra row of beta corresponding to a constant feature, also matching the shape of y and in consequence, the implementation algebra is just more natural this way.) However this may be argued to be a little inconsistent with categorical_logit_glm_lpmf so it's maybe up to a debate, but then the categorical is not implemented as multivariate even though it also uses beta matrix.
I chose to use "logit" in the name instead of "softmax" (even though it really is softmax) to be consistent with existing functions like multinomial_logit.
I am new to this, so if there are any improvements to be made, I will gladly listen. I tried to use efficient vectorized approach and utilize existing functions where applicable. Note however this uses its own softmax implementation, which is necessary for efficient vectorization and in my understanding can't be done by the existing library implementation the way it's needed here. Maybe if my other PR #3313 is approved, this could be made a few LOC shorter with a call to that.
As a personal note, this is a function I want available in Stan for my actual work. :)
Tests
Standard testing of the new functions introduced, both for the prim and cl variants.
Side Effects
None.
Release notes
Add multinomial_logit_glm_lpmf, including OpenCL support.
AI use disclosure
I used claude code w/ Sonnet to help with the work, but I critically reviewed/edited every single line, striving to match the general code quality and patterns within the library.
Machine information
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 20.04.3 LTS
Release: 20.04
Codename: focal
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Vmscape: Mitigation; IBPB before exit to userspace
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities
G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the implementation of the
multinomial_logit_glm_lpmf, including the OpenCL variant. A solution to #3149It computes, in an efficient vectorized way, exactly what one would expect:
I was trying to closely follow patterns in related functions like the
binomial_logit_glm_lmpfandcategorical_logit_glm_lpmfwhich this is a generalization of both.The typing:
yare a 2Darray [,] intnon-negative (rows=instances, columns=outcome classes)xarematrix(rows=instances, columns=features)betaare amatrix(rows=features, columns=outcome classes)alphamay be either amatrix(same shape asy) or arow_vector(length=outcome classes). Now this may seem a little irregular at first, but it makes sense when you really think about it. Other GLMs offer either avectororrealfor the intercept. In the multivariate case, the (univariate)vectorcorresponds to thematrixand the scalar to be copied for each instance is more naturally represented here as arow_vectorrather than a column. (It can be seen as an extra row ofbetacorresponding to a constant feature, also matching the shape ofyand in consequence, the implementation algebra is just more natural this way.) However this may be argued to be a little inconsistent withcategorical_logit_glm_lpmfso it's maybe up to a debate, but then the categorical is not implemented as multivariate even though it also uses beta matrix.I chose to use "logit" in the name instead of "softmax" (even though it really is softmax) to be consistent with existing functions like
multinomial_logit.I am new to this, so if there are any improvements to be made, I will gladly listen. I tried to use efficient vectorized approach and utilize existing functions where applicable. Note however this uses its own softmax implementation, which is necessary for efficient vectorization and in my understanding can't be done by the existing library implementation the way it's needed here. Maybe if my other PR #3313 is approved, this could be made a few LOC shorter with a call to that.
As a personal note, this is a function I want available in Stan for my actual work. :)
Tests
Standard testing of the new functions introduced, both for the prim and cl variants.
Side Effects
None.
Release notes
Add
multinomial_logit_glm_lpmf, including OpenCL support.AI use disclosure
I used claude code w/ Sonnet to help with the work, but I critically reviewed/edited every single line, striving to match the general code quality and patterns within the library.
Checklist
Copyright holder: me, jachymb@gmail.com
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested