Run unit tests on pull requests#173
Open
Robby955 wants to merge 1 commit into
Open
Conversation
Robby955
force-pushed
the
codex/run-tests-on-pull-requests
branch
from
9cd994f to
fe48153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requestevents as well aspusheventscontents: read; Pages/OIDC write permissions are only needed by the documentation deployment workflowWhy
Contributor PRs currently show no test check rollup unless maintainers run validation separately. Enabling the existing workflow on pull requests makes small maintenance PRs easier to evaluate with the same pytest path already used on pushes.
The test job does not publish GitHub Pages or request an OIDC token, so it can use least-privilege read access.
Validation
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/test.yaml"); puts "workflow yaml parsed"'git diff --check.venv/bin/pytest -q(29 passed, with the pre-existing Python 3.13 asyncio deprecation warning addressed separately in PR Avoid asyncio import deprecation warning #172)