Skip to content

Fix branch deletion 404 with Neon's api-client 2.7.2+ - #18

Merged
lirbank merged 3 commits into
mainfrom
fix-17
Aug 14, 2026
Merged

Fix branch deletion 404 with Neon's api-client 2.7.2+#18
lirbank merged 3 commits into
mainfrom
fix-17

Conversation

@lirbank

@lirbank lirbank commented Aug 8, 2026

Copy link
Copy Markdown
Member

Closes #17

Summary by CodeRabbit

  • Bug Fixes

    • Improved branch deletion reliability by updating requests to use the latest API format.
  • Chores

    • Updated supporting libraries and development tooling to newer compatible versions.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f8b5aba-530f-4ff8-8574-15f1afa915f9

📥 Commits

Reviewing files that changed from the base of the PR and between 047fa36 and 1319a2d.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • package.json
  • src/core.ts

📝 Walkthrough

Walkthrough

The change updates the Neon API client dependency range and development dependencies. Both branch deletion calls now use the client’s named options-object format for projectId and branchId.

Changes

Neon branch deletion

Layer / File(s) Summary
Update API client dependency contract
package.json
The @neondatabase/api-client requirement now starts at 2.7.3. The @types/pg, pg, prettier, and vitest development dependency ranges were also updated.
Use named branch deletion parameters
src/core.ts
deleteAllTestBranches and deleteBranch now pass projectId and branchId through an options object to deleteProjectBranch.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 1319a

The PR updates the API client dependency and branch-deletion calls. Merge is reasonable with owner confirmation that version 2.7.3 is the intended minimum and validation that both deletion paths work with the locked client version.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The API client update is in scope, but unrelated development dependency range updates are also included. Remove unrelated development dependency updates, or document why each update is required for the branch deletion fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the branch deletion 404 fix caused by newer Neon API client versions.
Linked Issues check ✅ Passed Both branch-deletion paths now use the required object parameters, addressing teardown 404 errors and leaked test branches for issue #17.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-17

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lirbank
lirbank marked this pull request as ready for review August 14, 2026 17:03
@lirbank
lirbank merged commit ef9a3d6 into main Aug 14, 2026
2 checks passed
@lirbank
lirbank deleted the fix-17 branch August 14, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deleteBranch calls deleteProjectBranch with positional args; @neondatabase/api-client 2.x expects an object -- every teardown 404s and leaks the branch

1 participant