[codex] harden package surface smoke#60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
npm pack --dry-run --jsonafter build and asserts the tarball includes the built CLI/MCP bin, plugin metadata, MCP wiring, registry metadata, and skill file.npm run buildto markdist/index.jsexecutable so the packaged bin target ships with mode0755.Why
The package claims to ship one CLI/MCP/plugin/skill surface, but a local dry-run pack before this change did not guarantee a built executable bin in the tarball. The new smoke test turns that release surface into a PR-time check.
Validation
npm ci --ignore-scriptsnpm run build && node --test --import tsx tests/package-surface.test.tsnpm testnpm run lintnpm run buildnpm audit --audit-level=highnpm pack --dry-run --json