Repository navigation
[9.x] Clean up revisions left behind by PublishedModelsControllerTest - #853
Merged
Merged
Conversation
…elsControllerTest` Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VNJoUuntDsQj9K8gSdRd6W
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where
PublishedModelsControllerTestleft revision files behind intests/__fixtures__/revisionsafter running.This was happening because the test overrides
statamic.revisions.pathand deletes that directory on tear down, but revisions are now written via the Stache store, whose directory is configured inTestCaseto point at the fixtures directory.This PR fixes it by deleting the fixtures directory on tear down, like
ModelRevisionsControllerTestandRestoreModelRevisionControlleralready do.