Fix broken corners on the selected rule row in the report - #684
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the selected rule row in the report had broken corners when it was the last row in the table.
This was happening because the accent around the selected row was drawn with inset box shadows. The last row's cells still had their grey bottom border, which follows the rounded corners, so the grey corner showed through next to the violet one.
This PR fixes it by colouring the actual borders instead: the selected row's bottom border when it's the last row, and the next row's top border otherwise. The 3px accent on the left is still an inset shadow.
Before
After
Fixes #683
Caused by #677