Repository navigation
Record errors when using the deferred or background queue drivers - #686
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where 404 errors weren't being recorded when using the
deferredorbackgroundqueue drivers.This was happening because both drivers run jobs via Laravel's
defer()helper, and deferred callbacks are only invoked when the response is successful (status code < 400). SinceRecordErroris dispatched while rendering a 404, the job was silently dropped every time.This PR fixes it by dispatching the
RecordErrorjob after the response when using either of those drivers, so it's run in a terminating callback regardless of the response's status code.Fixes #685