feat(discovery_kit_sdk): bump index revision on register/clear#181
Merged
Conversation
Call exthttp.BumpRevision() from Register and ClearRegisteredDiscoveries so the extension index ETag reflects the set of registered discoveries, target describers, attribute describers and enrichment rules, enabling the agent's index-response cache to invalidate on registration changes without a process restart. The runtime Discover endpoint's own ETag is left unchanged.
|
Claude finished @joshiste's task in 1m 5s —— View job Reviewing PR #181
ReviewThis is a small, focused change and looks correct.
No bugs, security issues, race conditions, or typos found. No concurrency issues introduced beyond what already existed in the package-level registries (unchanged by this PR). |
Registration installs routes on the process-global http.DefaultServeMux and ClearRegisteredDiscoveries does not remove them, so reusing the shared example id panicked on a duplicate route when the full package ran.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RegisterandClearRegisteredDiscoveriesnow callexthttp.BumpRevision()so the extension index ETag reflects the registered discoveries/target describers/attribute describers/enrichment rules.The runtime
Discover(discovered-targets) endpoint keeps its own existingIfNoneMatchHandler(LastModified())ETag — that's a different endpoint and is intentionally untouched.Why
Part of centralizing index-response caching in the SDKs (see steadybit/extension-kit#158). The index ETag becomes registration-scoped instead of frozen at process start.
Depends on
steadybit/extension-kit#158 —
exthttp.BumpRevisionis introduced there. CI on this PR is red until extension-kit is tagged; I'll bumpgo.mod/go.sumto the new tag as a follow-up commit.