Skip to content

chore: update action_kit_commons to v1.10.2#472

Open
achoimet wants to merge 1 commit into
mainfrom
chore/bump-action-kit-commons-1.10.2
Open

chore: update action_kit_commons to v1.10.2#472
achoimet wants to merge 1 commit into
mainfrom
chore/bump-action-kit-commons-1.10.2

Conversation

@achoimet

@achoimet achoimet commented Jul 9, 2026

Copy link
Copy Markdown
Member

Bumps action_kit_commons v1.10.0 → v1.10.2, pulling in steadybit/action-kit#462.

Why

Stopping any network attack on a stock multi-queue NIC (e.g. AWS ENA ens5) failed with:

Stop Error: Failed to revert network settings.
restore qdisc fq_codel on ens5: netlink receive: no such file or directory

The kernel attaches the default mq 0: root with one fq_codel 0: parent :N per TX queue, all with handle 0 — unaddressable via RTNETLINK, so the qdisc snapshot restore's Replace() failed with ENOENT even though the attack tree was already removed and the kernel had re-attached the identical defaults. v1.10.2 skips those kernel-default children on restore (lossless).

Since this comes from v1.10.0, it also picks up the v1.10.1 hardening (runtime crash-path guards; rejection of newline injection into tc/iptables/dig batch stdin).

Unit tests pass locally (config, extcontainer).

Fixes the Stop error 'restore qdisc fq_codel on <iface>: netlink
receive: no such file or directory' on stock multi-queue NICs (e.g.
AWS ENA) whose default mq 0: tree is attached anonymously by the
kernel: the qdisc snapshot restore now skips those kernel-default
children instead of attempting an unaddressable RTNETLINK replace.
Also picks up the v1.10.1 crash-path and stdin-injection hardening.
See steadybit/action-kit#462.
@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown

Claude finished @achoimet's task in 1m 23s —— View job


Claude's Review

  • Check for previously addressed review threads (none found)
  • Gather context (diff, changelog, go.mod/go.sum)
  • Review changes for bugs, security, performance, concurrency issues
  • Post findings

Summary

This is a minimal, mechanical dependency bump (action_kit_commons v1.10.0 → v1.10.2) touching only go.mod, go.sum, and CHANGELOG.md — no application code changed.

  • go.mod/go.sum diffs are consistent: single dependency version bump, corresponding hash updates, no unrelated changes.
  • CHANGELOG.md entry accurately describes the fix (qdisc restore on multi-queue NICs) and correctly notes the v1.10.1 hardening picked up transitively.
  • No code in this repo directly touches the changed behavior (qdisc restore logic lives in action_kit_commons), so there's no local logic to review for bugs/races/security here.

Note: I wasn't able to run go build/go vet locally in this sandbox (commands require approval not available in this automated context) — the ci workflow run is still queued and will provide the authoritative build/test signal.

Nothing to flag. LGTM pending CI.

@achoimet achoimet enabled auto-merge (squash) July 9, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant