chore: update action_kit_commons to v1.10.2#472
Open
achoimet wants to merge 1 commit into
Open
Conversation
Fixes the Stop error 'restore qdisc fq_codel on <iface>: netlink receive: no such file or directory' on stock multi-queue NICs (e.g. AWS ENA) whose default mq 0: tree is attached anonymously by the kernel: the qdisc snapshot restore now skips those kernel-default children instead of attempting an unaddressable RTNETLINK replace. Also picks up the v1.10.1 crash-path and stdin-injection hardening. See steadybit/action-kit#462.
|
Claude finished @achoimet's task in 1m 23s —— View job Claude's Review
SummaryThis is a minimal, mechanical dependency bump (
Note: I wasn't able to run Nothing to flag. LGTM pending CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
action_kit_commonsv1.10.0 → v1.10.2, pulling in steadybit/action-kit#462.Why
Stopping any network attack on a stock multi-queue NIC (e.g. AWS ENA
ens5) failed with:The kernel attaches the default
mq 0:root with onefq_codel 0: parent :Nper TX queue, all with handle 0 — unaddressable via RTNETLINK, so the qdisc snapshot restore'sReplace()failed with ENOENT even though the attack tree was already removed and the kernel had re-attached the identical defaults. v1.10.2 skips those kernel-default children on restore (lossless).Since this comes from v1.10.0, it also picks up the v1.10.1 hardening (runtime crash-path guards; rejection of newline injection into
tc/iptables/digbatch stdin).Unit tests pass locally (
config,extcontainer).