Skip to content

chore(deps): bump go to 1.26.5#111

Merged
joshiste merged 1 commit into
mainfrom
chore/bump-go-1.26.5
Jul 9, 2026
Merged

chore(deps): bump go to 1.26.5#111
joshiste merged 1 commit into
mainfrom
chore/bump-go-1.26.5

Conversation

@joshiste

@joshiste joshiste commented Jul 9, 2026

Copy link
Copy Markdown
Member

Bump Go to 1.26.5 in go.mod and CI. Also ran go fix and go mod tidy.

@joshiste joshiste enabled auto-merge (squash) July 9, 2026 18:32
@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown

Claude finished @joshiste's task in 54s —— View job


Claude's Review

Todo list:

  • Check previously unresolved review threads for fixes (none found)
  • Gather context (diff, changed files)
  • Review changed code
  • Post final feedback

Summary

This is a small, low-risk dependency bump PR (Go 1.26.4 → 1.26.5) plus the output of go fix/go mod tidy. Reviewed all 4 changed files:

  • .github/workflows/ci.yml: version pin bump only, no issues.
  • go.mod: go directive bump, dependency list unchanged otherwise.
  • extloadtest/deterministic.go: go fix replaced the manual round-then-clamp with the max builtin:
    period = max(int64(math.Round(1.0/spec.Rate)), 1)
    This is behaviorally identical to the old if period < 1 { period = 1 } clamp — no change in logic.
  • extloadtest/deterministic_test.go: go fix modernized for i := 0; i < n; i++ loops to for i := range n, again a purely mechanical, behavior-preserving change (Go 1.22+ range-over-int).

No bugs, security issues, race conditions, or performance concerns found. Nothing here needs changes.

Note: I was unable to run go build/go vet/go test in this environment (sandboxed shell required approval that wasn't available), so this review is based on manual code inspection of the diff, which is small and mechanical enough to review with confidence.

@joshiste joshiste force-pushed the chore/bump-go-1.26.5 branch from 3322379 to 4d9dc61 Compare July 9, 2026 18:37
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

@joshiste joshiste merged commit 0c6f20c into main Jul 9, 2026
14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2026
@joshiste joshiste deleted the chore/bump-go-1.26.5 branch July 10, 2026 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant