copy(preferences): "Usage data sharing" toggle + accurate disclosure (master backport of #2922) - #2924
Open
piyalbasu wants to merge 3 commits into
Open
copy(preferences): "Usage data sharing" toggle + accurate disclosure (master backport of #2922)#2924piyalbasu wants to merge 3 commits into
piyalbasu wants to merge 3 commits into
Conversation
… + accurate disclosure The toggle was labeled "Anonymous data sharing" and its copy claimed Freighter "will never collect your personal information such as IP address, keys, balance or transaction amounts" — which is inaccurate: we send public keys (the seed-derived auth key as user_id + a hashed account key), IP address, and a persistent cross-platform ID to our analytics/crash-reporting providers. Relabel to "Usage data sharing" and replace the description with an accurate disclosure. Removes the stale pt strings so they fall back to English until a professional pt translation of the new copy is added. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Addresses review feedback on #2922. Two deviations from the locale workflow in extension/LOCALIZATION.MD: - The two new keys were missing from pt/translation.json. Every other key (839/839 before this PR) exists in both catalogs, with the English string as the value where no translation exists yet (39 such keys). Added both keys to pt with English placeholder values, matching `useKeysAsDefaultValue: true` in webpack.extension.js — same rendered output as the fallbackLng path, but the catalogs stay aligned so `yarn build:translations` produces no diff. - Both new en keys were inserted where the old "Anonymous data sharing" key sat (the `An…` block) rather than in sort order. Moved to their correct positions ("Help us improve…" after "Help", "Usage data sharing" after "Upload Contract Wasm") so `sort: true` is a no-op. A reviewed Portuguese translation of the new label + disclosure remains a follow-up; leaving unreviewed machine translation out of a privacy disclosure on purpose. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Replaces the English placeholder values added in a05db85 with Brazilian Portuguese, for native-speaker review in the PR. "Usage data sharing" -> "Compartilhamento de dados de uso" "Help us improve Freighter by sharing usage, device, and activity data, ..." -> "Ajude-nos a melhorar o Freighter compartilhando dados de uso, do dispositivo e de atividade — incluindo suas chaves públicas, endereço IP e um ID persistente que vincula sua carteira entre a extensão e o aplicativo móvel — com nossos provedores de análise de dados e de relatórios de falhas. Você pode desativar essa opção a qualquer momento. Consulte nossa Política de Privacidade para mais detalhes." Terminology follows the existing catalog rather than inventing new terms: "Política de Privacidade" (already a key), "chave pública", "dispositivo", "carteira", "extensão", and the catalog's "o Freighter" article convention. The em-dash pair keeps the English sentence structure intact: "with our analytics and crash-reporting providers" attaches to "sharing", not to the enumerated data. A comma-only rendering would leave "com nossos provedores" far from "compartilhando" and could be misread as scoping only the persistent ID — unacceptable ambiguity in a privacy disclosure, which is the class of error this copy change exists to fix. Label length is 32 chars vs the 33-char label it replaces ("Compartilhamento anônimo de dados"), so the section title that renders inline with the toggle carries no new overflow risk. Verified: catalogs at 841/841 en/pt parity, 0 keys missing in pt, and the count of English-placeholder pt values is back to the 39 pre-existing ones. Ran the (patched) translation build against this branch and confirmed it is a no-op on both new keys — the parser preserves existing pt values rather than overwriting them with the English default, and the hand-placed sort positions match what it generates exactly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Backports accurate usage-data disclosure copy from #2922 to master.
Changes:
- Renames the data-sharing toggle.
- Adds accurate English and Portuguese disclosures.
- Removes obsolete translation keys.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Preferences/index.tsx |
Updates the toggle label and disclosure. |
locales/en/translation.json |
Updates English translations. |
locales/pt/translation.json |
Adds Portuguese copy; native review remains required. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "Got it": "Entendi", | ||
| "Hash": "Hash", | ||
| "Help": "Ajuda", | ||
| "Help us improve Freighter by sharing usage, device, and activity data, including your public keys, IP address, and a persistent ID that links your wallet across extension and mobile, with our analytics and crash-reporting providers. You can turn this off at any time. See our Privacy Policy for details.": "Ajude-nos a melhorar o Freighter compartilhando dados de uso, do dispositivo e de atividade — incluindo suas chaves públicas, endereço IP e um ID persistente que vincula sua carteira entre a extensão e o aplicativo móvel — com nossos provedores de análise de dados e de relatórios de falhas. Você pode desativar essa opção a qualquer momento. Consulte nossa Política de Privacidade para mais detalhes.", |
Contributor
|
PR Preview build is ready: https://github.com/stellar/freighter/releases/tag/untagged-d70ba12a53721cbfec07 (SDF collaborators only — install instructions in the release description) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Trunk backport of #2922 (rename the data-sharing toggle to "Usage data sharing" + accurate disclosure copy). #2922 was retargeted onto the in-flight
v5.44.0release branch for the current beta; this PR lands the same copy onmaster.Implementation details (for agents)
What changed:
extension/src/popup/views/Preferences/index.tsx(label + description key),extension/src/popup/locales/en/translation.jsonandpt/translation.json—Anonymous data sharing→Usage data sharingplus the new disclosure string. Content is identical to #2922 (the 3 touched files are byte-identical onv5.44.0andmaster).Relationship to #2922: #2922 → base
v5.44.0(beta); this PR → basemaster(trunk).