Skip to content

Initialize the image in nil so no flicker from the previous image #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgalindosl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Initialize the image in nil so no flicker from the previous image #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4856d6
Initialize the image in nil so no flicker from the previous image is …
jgalindosl Sep 22, 2020
6a17d64
Ghost images
jgalindosl Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion MessengerKit/Collection View/Cells/Media/MSGImageCollectionViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ class MSGImageCollectionViewCell: MSGMessageCell {
}

private func downloadImage(from url: URL) {
imageView.image = nil
print("Download Started")
getData(from: url) { data, response, error in
guard let data = data, error == nil else { return }
Expand All @@ -47,7 +48,7 @@ class MSGImageCollectionViewCell: MSGMessageCell {

override func awakeFromNib() {
super.awakeFromNib()

imageView.image = nil
imageView.layer.cornerRadius = 18
imageView.layer.masksToBounds = true
imageView.isUserInteractionEnabled = true
Expand Down