Skip to content

feat(docker): Turn off password saving in the image - #1404

Open
benjamin-di wants to merge 5 commits into
stickerdaniel:mainfrom
benjamin-di:feature/1403-login-viewer-sign-in-only
Open

benjamin-di wants to merge 5 commits into
stickerdaniel:mainfrom
benjamin-di:feature/1403-login-viewer-sign-in-only

Conversation

@benjamin-di

@benjamin-di benjamin-di commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The Docker image installs a managed Chromium policy that turns off the password manager and address and card autofill, so the login viewer's browser no longer offers to save the LinkedIn password into the profile. The README and Docker Hub guide explain this and advise skipping the passkey option, which cannot reach the container.

The policy contains exactly those three settings and applies to every browser launch in the image. The viewer's launch flags and passkey behavior are unchanged.

Part of #1403.

Verification

  • Rebased onto main 8c3bb5ab572c, head b434c3205ed1. Contribution patches are unchanged.
  • Full suite: 8,505 passed, 109 failed and 896 skipped. Both rebased branches have identical failing test identities. A selected rerun of all 109 on exact upstream also fails all 109; no candidate-only failure was found. This is not a full-green result or a second full upstream suite.
  • Ruff lint/format, architecture generation, policy traces, strict public scan and whitespace checks pass. Whole-repository type checking reports the identical 389 diagnostics on both candidates and upstream after checkout-path normalization.
  • The Docker policy assertions pass; no new detector measurements or repeat save-password UI observation was performed.
  • No Docker image build, native host/browser qualification or live LinkedIn check was performed for this rebase. Earlier detector measurements remain historical evidence with their stated scope.

Synthetic prompt

Install a managed Chromium policy in the Docker image that turns off the password manager and address and card autofill, and nothing else. Pin its contents with a test and document the measured kiosk and wider-policy results as not adopted.

benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Oct 23, 2026
@github-actions github-actions Bot added the enhancement New feature or request label Oct 23, 2026
@benjamin-di
benjamin-di marked this pull request as ready for review October 23, 2026 12:06
@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The policy affects browser launches within the Docker image, across login and server workflows.

The required detector measurements for the shipped policy must be completed before merging.

Findings

  1. P2 Shipped policy lacks required measurements ▶
Fix with agent prompt
### Issue 1
scripts/chromium-policy.json:2-4
The image installs this three-setting browser policy, but the recorded detector results cover an older, wider policy. `docs/browser-fingerprint.md` explicitly says this subset was not measured on its own.

`AGENTS.md` requires measurements against the four detectors for launch-configuration changes. Measure this exact policy and record the results before merging to satisfy that requirement.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The Docker image adds a managed browser policy that disables password saving and address and card autofill.

  • Docker browsers stop offering password saving and address or card autofill.

Both earlier, unnumbered findings are addressed: the redundant kiosk test is gone, and the stale measurement paragraph now links to the dated comparison.

Reviews (14) · Last reviewed commit: "fix(docker): Keep only the password and ..." · Reviewed by Greptile

Comment thread tests/test_login_viewer.py Resolved
benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Oct 24, 2026
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from 3343ae9 to fb53d9e Compare October 24, 2026 01:52
@benjamin-di

Copy link
Copy Markdown
Contributor Author

Completed the native amd64 four-detector comparison, with three cold launches each of upstream, policy only, kiosk only and combined. Kiosk raises CreepJS's like-headless score 44% → 50% via the fullscreen heuristic; lies remain zero, and all fpscanner/rebrowser outcomes are unchanged. Existing warnings, unavailable WebGPU signals, offline CSP limits and raw JA4 variation are documented. The policy loading control and all teardown checks passed. Arm64 remains unmeasured. This commit only adds evidence to the documentation.

benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Oct 25, 2026
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from 0208085 to 18c60da Compare October 25, 2026 04:16
benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Oct 26, 2026
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from 18c60da to d79d181 Compare October 26, 2026 12:37
Comment thread docs/browser-fingerprint.md Resolved
benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Oct 28, 2026
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from d881ed0 to 0b6ae7b Compare October 28, 2026 04:29
@benjamin-di benjamin-di changed the title feat(docker): Keep the login viewer on the sign-in feat(docker): Turn off password saving in the image Oct 28, 2026
benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Oct 28, 2026
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from 0b6ae7b to 1c5a5ce Compare October 28, 2026 13:21
benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Oct 30, 2026
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from 1c5a5ce to 10246d1 Compare October 30, 2026 06:09
benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Nov 1, 2026
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from 10246d1 to 176d426 Compare November 1, 2026 22:15
@benjamin-di

Copy link
Copy Markdown
Contributor Author

Could you grant an exception to the required attribution footer and check-bot-coauthors for this PR and #1383? I cannot supply the required footer. The code, regression tests and validation results remain available in the PR descriptions.

benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Nov 4, 2026
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from 176d426 to 1dc2ceb Compare November 4, 2026 15:12
benjamin-di added a commit to benjamin-di/linkedin-mcp-server that referenced this pull request Nov 5, 2026
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from 1dc2ceb to b434c32 Compare November 5, 2026 00:40
The viewer's browser showed an address bar and tab strip in a 945x1060
window, offered to save the LinkedIn password into the profile, and let
Ctrl+L, Ctrl+T or Ctrl+O leave the sign-in. A viewer login now launches it
with --kiosk, and the image installs a managed Chromium policy that turns
off the password manager, autofill, file dialogs and downloads and blocks
Chromium's local schemes. LinkedIn's pages and DevTools stay untouched.
Every launch in the image reads its managed policy, so the file-dialog,
download and URL-blocklist rules applied to the browser the server drives as
well as to the viewer's. Kiosk mode raised CreepJS's like-headless score from
44% to 50%. The viewer now launches as before, and the policy only turns off
the password manager and address and card autofill.
@benjamin-di
benjamin-di force-pushed the feature/1403-login-viewer-sign-in-only branch from b434c32 to aeff8df Compare November 15, 2026 04:00
Comment on lines +2 to +4
"PasswordManagerEnabled": false,
"AutofillAddressEnabled": false,
"AutofillCreditCardEnabled": false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Shipped policy lacks required measurements

The image installs this three-setting browser policy, but the recorded detector results cover an older, wider policy. docs/browser-fingerprint.md explicitly says this subset was not measured on its own.

AGENTS.md requires measurements against the four detectors for launch-configuration changes. Measure this exact policy and record the results before merging to satisfy that requirement.

Context Used: AGENTS.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: scripts/chromium-policy.json
Line: 2-4

Comment:
**Shipped policy lacks required measurements**

The image installs this three-setting browser policy, but the recorded detector results cover an older, wider policy. `docs/browser-fingerprint.md` explicitly says this subset was not measured on its own.

`AGENTS.md` requires measurements against the four detectors for launch-configuration changes. Measure this exact policy and record the results before merging to satisfy that requirement.

**Context Used:** AGENTS.md ([source](https://github.com/stickerdaniel/linkedin-mcp-server/blob/main/AGENTS.md))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant