Repository navigation
feat(docker): Turn off password saving in the image - #1404
benjamin-di wants to merge 5 commits into
Conversation
[Medium impact] The policy affects browser launches within the Docker image, across login and server workflows. The required detector measurements for the shipped policy must be completed before merging. Findings
Fix with agent prompt### Issue 1
scripts/chromium-policy.json:2-4
The image installs this three-setting browser policy, but the recorded detector results cover an older, wider policy. `docs/browser-fingerprint.md` explicitly says this subset was not measured on its own.
`AGENTS.md` requires measurements against the four detectors for launch-configuration changes. Measure this exact policy and record the results before merging to satisfy that requirement.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryThe Docker image adds a managed browser policy that disables password saving and address and card autofill.
Both earlier, unnumbered findings are addressed: the redundant kiosk test is gone, and the stale measurement paragraph now links to the dated comparison. Reviews (14) · Last reviewed commit: "fix(docker): Keep only the password and ..." · Reviewed by Greptile |
3343ae9 to
fb53d9e
Compare
|
Completed the native amd64 four-detector comparison, with three cold launches each of upstream, policy only, kiosk only and combined. Kiosk raises CreepJS's like-headless score 44% → 50% via the fullscreen heuristic; lies remain zero, and all fpscanner/rebrowser outcomes are unchanged. Existing warnings, unavailable WebGPU signals, offline CSP limits and raw JA4 variation are documented. The policy loading control and all teardown checks passed. Arm64 remains unmeasured. This commit only adds evidence to the documentation. |
0208085 to
18c60da
Compare
18c60da to
d79d181
Compare
d881ed0 to
0b6ae7b
Compare
0b6ae7b to
1c5a5ce
Compare
1c5a5ce to
10246d1
Compare
10246d1 to
176d426
Compare
|
Could you grant an exception to the required attribution footer and |
176d426 to
1dc2ceb
Compare
1dc2ceb to
b434c32
Compare
The viewer's browser showed an address bar and tab strip in a 945x1060 window, offered to save the LinkedIn password into the profile, and let Ctrl+L, Ctrl+T or Ctrl+O leave the sign-in. A viewer login now launches it with --kiosk, and the image installs a managed Chromium policy that turns off the password manager, autofill, file dialogs and downloads and blocks Chromium's local schemes. LinkedIn's pages and DevTools stay untouched.
Every launch in the image reads its managed policy, so the file-dialog, download and URL-blocklist rules applied to the browser the server drives as well as to the viewer's. Kiosk mode raised CreepJS's like-headless score from 44% to 50%. The viewer now launches as before, and the policy only turns off the password manager and address and card autofill.
b434c32 to
aeff8df
Compare
| "PasswordManagerEnabled": false, | ||
| "AutofillAddressEnabled": false, | ||
| "AutofillCreditCardEnabled": false |
There was a problem hiding this comment.
Shipped policy lacks required measurements
The image installs this three-setting browser policy, but the recorded detector results cover an older, wider policy. docs/browser-fingerprint.md explicitly says this subset was not measured on its own.
AGENTS.md requires measurements against the four detectors for launch-configuration changes. Measure this exact policy and record the results before merging to satisfy that requirement.
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: scripts/chromium-policy.json
Line: 2-4
Comment:
**Shipped policy lacks required measurements**
The image installs this three-setting browser policy, but the recorded detector results cover an older, wider policy. `docs/browser-fingerprint.md` explicitly says this subset was not measured on its own.
`AGENTS.md` requires measurements against the four detectors for launch-configuration changes. Measure this exact policy and record the results before merging to satisfy that requirement.
**Context Used:** AGENTS.md ([source](https://github.com/stickerdaniel/linkedin-mcp-server/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
The Docker image installs a managed Chromium policy that turns off the password manager and address and card autofill, so the login viewer's browser no longer offers to save the LinkedIn password into the profile. The README and Docker Hub guide explain this and advise skipping the passkey option, which cannot reach the container.
The policy contains exactly those three settings and applies to every browser launch in the image. The viewer's launch flags and passkey behavior are unchanged.
Part of #1403.
Verification
main8c3bb5ab572c, headb434c3205ed1. Contribution patches are unchanged.Synthetic prompt