Repository navigation
Conversation
The comment on RESULTS_PER_LINKEDIN_PAGE described only the classic search page. The redesigned /jobs/search-results/ page renders 25 cards per navigation, the same as the stride, so say that the match is a coincidence and the stride still must not drive the offset.
shbernal
marked this pull request as ready for review
November 14, 2026 17:01
Contributor
[Low impact] This comment-only change appears safe to merge. SummaryUpdates the comment above
Reviews (1) · Last reviewed commit: "docs(jobs): Give cards per page on each ..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1520
Summary
The comment on
RESULTS_PER_LINKEDIN_PAGEdescribed only the classic search page, which rendered 10 or 11 cards per navigation. It now also says that the redesigned/jobs/search-results/page renders 25, the same as the stride, and that the match is a coincidence: the offset still follows what each page rendered. Comment only, no behaviour change.Verification
ruff,ty,tests/linkedin/test_job_policy.py, the policy-trace and architecture-doc tests pass.d5a81d71): every job passed, thetestjob included (run).Synthetic prompt
Implemented with Claude Opus 5.5 (high) in Claude Code via tmux.
Note
Docs: clarify card counts per page in
RESULTS_PER_LINKEDIN_PAGEcommentRewrites the comment in job_policy.py to distinguish the two LinkedIn job search pages. The classic
/jobs/search/page shows 10 or 11 jobs despite advertising 25 per page, while the redesigned/jobs/search-results/page shows 25. The note that the stride only checks for past-last-page search is kept. Comment-only change.Macroscope summarized d5a81d7.