Skip to content

docs(jobs): Give cards per page on each search page - #1522

Open
shbernal wants to merge 1 commit into
stickerdaniel:mainfrom
shbernal:docs/search-page-cards
Open

shbernal wants to merge 1 commit into
stickerdaniel:mainfrom
shbernal:docs/search-page-cards

Conversation

@shbernal

@shbernal shbernal commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1520

Summary

The comment on RESULTS_PER_LINKEDIN_PAGE described only the classic search page, which rendered 10 or 11 cards per navigation. It now also says that the redesigned /jobs/search-results/ page renders 25, the same as the stride, and that the match is a coincidence: the offset still follows what each page rendered. Comment only, no behaviour change.

Verification

  • ruff, ty, tests/linkedin/test_job_policy.py, the policy-trace and architecture-doc tests pass.
  • Full suite in fork CI on this head (d5a81d71): every job passed, the test job included (run).

Synthetic prompt

Update the comment above RESULTS_PER_LINKEDIN_PAGE in job_policy.py: the classic /jobs/search/ page rendered 10 or 11 cards per navigation, the redesigned /jobs/search-results/ page renders 25, so the match with the stride is a coincidence and only the past-the-last-page check may use the constant.

Implemented with Claude Opus 5.5 (high) in Claude Code via tmux.

Note

Docs: clarify card counts per page in RESULTS_PER_LINKEDIN_PAGE comment

Rewrites the comment in job_policy.py to distinguish the two LinkedIn job search pages. The classic /jobs/search/ page shows 10 or 11 jobs despite advertising 25 per page, while the redesigned /jobs/search-results/ page shows 25. The note that the stride only checks for past-last-page search is kept. Comment-only change.

Macroscope summarized d5a81d7.

The comment on RESULTS_PER_LINKEDIN_PAGE described only the classic
search page. The redesigned /jobs/search-results/ page renders 25 cards
per navigation, the same as the stride, so say that the match is a
coincidence and the stride still must not drive the offset.
@shbernal
shbernal marked this pull request as ready for review November 14, 2026 17:01
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 14, 2026
@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This comment-only change appears safe to merge.

Summary

Updates the comment above RESULTS_PER_LINKEDIN_PAGE.

  • The job-search note explains why 25 cards can match the offset by chance.

Reviews (1) · Last reviewed commit: "docs(jobs): Give cards per page on each ..." · Reviewed by Greptile

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] RESULTS_PER_LINKEDIN_PAGE comment describes only the classic search page

1 participant