Repository navigation
Conversation
FredApps
marked this pull request as ready for review
October 11, 2026 19:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Malformed or unknown explicit targets now fail before mutation for
layer.delete,layer.duplicate,layer.setProps,layer.template,layer.merge,layer.reverse,layer.hideOthers,layer.outlineOthers, andlayer.lockOthers, pluslayer.collectInNew.idsandlayer.flatten.id. Complete target arrays are validated before the existing work cap is applied.Omitted defaults,
idsprecedence, and explicit empty-list behavior are preserved. An empty keep list retains the all-layer effects of the Others commands. This addresses part of #785; it does not cover every selector or close the whole issue.Implementation and testing were AI-assisted under FredApps.
How it was tested
cargo xtask cigates passed: 5,364 tests passed, zero failed, and four ignored.Tested head:
8d60ff69055d421f3c624543ddcf8ee0d83262b5; tree:fa22be9876b984f8dbd1383141db0ddf6fdf2693; base:53bc86fdb454ed33cd26cba5e29695ebe0befeff.Main advanced to
2ac3ba2b866ad9d34b2252dd8024f73e34f4b2b8without changes in the affected files. Integration with that newer main was not tested. No hosted CI or runtime MCP transport pass is claimed.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm), locally on the tested head above.unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no new unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md(no new assets).