Repository navigation
i18n (cs): translate labels that bypass the catalog lookup (file filters, diagnostics, credits, gradients, print marks) - #1259
Merged
Conversation
Localize native/web file filters, diagnostic labels, numbered presets and contributor tooltips with English fallback and Czech plural forms. Fix gradient adjective agreement and disambiguate Japanese printer marks in PDF/Print choices and summaries. Keep file extensions and names intact. Add Czech catalog rows and regression coverage; update localization evidence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bflatastic
force-pushed
the
cs-ui-code
branch
from
October 12, 2026 01:18
794ab07 to
e3dec2e
Compare
Member
|
Thanks @Losminek! The Czech labels that bypassed the catalog now show in Czech. I rebased it onto main and merged it after the full local gate passed on the combined branch. The rebase had conflicts with tonight's other merges: |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1189 and #1226 (Czech catalog). The catalog is complete, but a few labels never reach the
catalog lookup, so they still show in English under Czech. This PR translates them where they are shown,
from a variable or a template, so every other language keeps its current behaviour and falls back to
English. No new
tl!("literal")keys, so onlycs.tsvgains rows.What changes
apps/vectorcraft/src/main.rs, webapps/vectorcraft-web/src/web.rs):filter names such as "All readable files", "Swatch libraries", "PDF presets" are looked up when the
dialog is built (context
file-filter). Extensions and format names stay as they are.chrome.rs): the wordsrender/uiare looked up (contextdiagnostics);numbers,
msandfpsstay.Preset {number}instead offormat!("Preset {}").PRscolumn header and the contributor tooltip go through named placeholders, with@pluralrows for PR and commit counts. Names and handles stay unchanged.{kind} Gradientnow reads"Lineární přechod" / "Kruhový přechod";
Radialgot agradient-kindcontext for the masculine form.The mark style now uses a
mark-stylecontext ("Japonské"), so the language stays "Japonština". Englishoutput and the stored id are unchanged.
docs/localization-parity.md,docs/gaps.md,docs/roadmap.md,docs/target-app-parity.mdandROADMAP.mdnote the change (scores unchanged; the stale "Czech (menus only)" line is corrected).I also checked the search box placeholder, Home screen, status bar, toolbar and panel tooltips and the
Preferences window: they already use lookups, so nothing else needed changing there. Workspace names stay
English on purpose (
MENU_KEEP_AS_IS).Checks
Clean environment,
--locked:cargo fmt --all -- --checkclean;cargo test -p vectorcraft-ui-egui:1,043 passed, 0 failed (including the bundled-font glyph test);
cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningsclean; desktop and wasmcargo checkOK.Review
The 19 new Czech rows were drafted with AI assistance (Codex and Claude) and checked against the existing
catalog terminology; they sit under a comment in
cs.tsvand have not yet been proofread by a native speaker. Wording worth a second look: "Všechny čitelné soubory" (All readablefiles), "Všechny soubory pro umístění" (All placeable files) and the contributor tooltip.
🤖 Generated with Claude Code