Repository navigation
Feat/monorepo sync - #1052
Merged
Merged
Feat/monorepo sync#1052
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Several confirmed issues need correction (Editor PointDto disambiguation bug, inconsistent toolbar small sizing, JsonDecoderPartial unsafe cursor advancement on EOF, and rpc-client missing direct deps for createFetchClient).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR performs a broad “monorepo sync” across the workspace: adding new packages/projects, aligning build references, and updating multiple libraries (UI, RPC, JSON/CRDT tooling) to match the updated internal APIs and dependency versions.
Changes:
- Added/registered new workspace packages (
json-crdt,click-type) and updated TypeScript solution references. - Refactored/expanded UI components (new Grid/Tree primitives, Fields system, Label→Pill/Badge changes, styling/token additions).
- Updated RPC client/server codec plumbing (introducing
RpcBinBatchCodec, adding HTTP1 CORS wiring) plus assorted perf/test/bench adjustments across packages.
File summaries
| File | Description |
|---|---|
| tsconfig.solution.json | Add project references for new workspace packages. |
| packages/util/src/bench/runBenchmark.ts | Import ordering tweak for benchmark runner. |
| packages/util/package.json | Add optional benchmark peer + dev deps for bench tooling. |
| packages/ui/src/styles/Styles.ts | Expose easing helpers + add CSS vars. |
| packages/ui/src/styles/color/ThemeColor.ts | Add ThemeColor.from + softTint helper. |
| packages/ui/src/markdown/renderers/renderLink.tsx | Handle unresolved link refs gracefully. |
| packages/ui/src/icons/interactive/Close/index.tsx | Close icon styling tweak. |
| packages/ui/src/5-block/Tree/index.ts | New Tree public exports. |
| packages/ui/src/5-block/Tree/context.ts | New Tree context hook. |
| packages/ui/src/5-block/Tree/constants.ts | New Tree sizing/behavior constants. |
| packages/ui/src/5-block/Grid/index.ts | New Grid public exports. |
| packages/ui/src/5-block/Grid/context.ts | New Grid context hook. |
| packages/ui/src/5-block/Grid/constants.ts | New Grid sizing/behavior constants. |
| packages/ui/src/5-block/Grid/components/GridIconCell.tsx | New Grid icon-column cell component. |
| packages/ui/src/5-block/Grid/columnTypes.ts | New column type registry/comparators. |
| packages/ui/src/5-block/FeatureGrid/index.tsx | Switch badge UI from Label to Pill. |
| packages/ui/src/5-block/CodeCard/index.tsx | Switch language chip from Label to Pill. |
| packages/ui/src/4-card/Toolbar/ToolbarPane.tsx | Add small sizing option for panes. |
| packages/ui/src/4-card/Toolbar/ToolbarMenu/types.ts | Document small option for toolbar menus. |
| packages/ui/src/4-card/Toolbar/ToolbarMenu/ToolbarMenuMore.tsx | Import ordering normalization. |
| packages/ui/src/4-card/Toolbar/ToolbarMenu/ToolbarMenuItemTerminal.tsx | Import ordering normalization. |
| packages/ui/src/4-card/Toolbar/ToolbarMenu/ExpandSubChildren.tsx | Propagate small to submenu items. |
| packages/ui/src/4-card/Toolbar/ToolbarMenu/ExpandChildren.tsx | Propagate small to children items. |
| packages/ui/src/4-card/Toolbar/ToolbarItem.tsx | Adjust small toolbar button sizing. |
| packages/ui/src/4-card/ScrollArea/index.ts | Export new virtual scroll primitives. |
| packages/ui/src/4-card/Fields/variants.ts | Introduce field density/edit-mode presets. |
| packages/ui/src/4-card/Fields/ValueSource.ts | Add value provenance abstraction. |
| packages/ui/src/4-card/Fields/ValuePopover.tsx | Shared popover chrome for value cells. |
| packages/ui/src/4-card/Fields/str.ts | String validation + hint helpers. |
| packages/ui/src/4-card/Fields/num.ts | Numeric validation + hint helpers. |
| packages/ui/src/4-card/Fields/metrics.ts | Field row sizing/rhythm helpers. |
| packages/ui/src/4-card/Fields/FieldGhostButton.tsx | Add shared “ghost” button surface. |
| packages/ui/src/4-card/Fields/FieldActions.tsx | Add field row action strip (ToolbarMenu-based). |
| packages/ui/src/4-card/Fields/EmptyValue.tsx | Add “Empty” placeholder with keyboard handling. |
| packages/ui/src/4-card/Fields/date.ts | Date bounds validation helper. |
| packages/ui/src/4-card/Fields/components/OptionalBadge.tsx | Fix import paths after refactors. |
| packages/ui/src/4-card/Fields/components/FieldHint.tsx | Add constraint/warning hint pill w/ tooltip. |
| packages/ui/src/4-card/Fields/components/DefaultableToggle.tsx | Focus-visible styling + import path normalization. |
| packages/ui/src/4-card/Fields/components/css.tsx | Shared CSS rule for args block layout. |
| packages/ui/src/4-card/Fields/components/AutoValue.tsx | Make auto value focusable + improved rendering. |
| packages/ui/src/4-card/Fields/components/ArgSelect/SingleSelectMenu.tsx | New select menu builder + single-select menu. |
| packages/ui/src/4-card/Fields/components/ArgSelect/SelectValueView.tsx | Multi-select resting value view + validation marker. |
| packages/ui/src/4-card/Fields/components/ArgSelect/SelectMenuBody.tsx | Shared menu body for single/multi select. |
| packages/ui/src/4-card/Fields/components/ArgSelect/index.ts | Barrel exports for ArgSelect components/utilities. |
| packages/ui/src/4-card/Fields/components/ArgSelect/ArgSelectReveal.tsx | Reveal-mode select field using ValueCell popover. |
| packages/ui/src/4-card/Fields/components/ArgInfo.tsx | New read-only info value renderer. |
| packages/ui/src/4-card/Fields/components/ArgDate.tsx | New date editor field renderer. |
| packages/ui/src/4-card/Fields/components/ArgCode.tsx | New code/id display with copy affordance. |
| packages/ui/src/4-card/ContextMenu/ContextMenu/state.tsx | Esc behavior routing tweak. |
| packages/ui/src/4-card/ContextMenu/ContextMenu/index.tsx | ContextMenu component import reordering + focus logic removal. |
| packages/ui/src/4-card/ContextMenu/ContextMenu/ContextMenuSearch/index.tsx | Close button spacing tweak in search input. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgStr.tsx | Remove legacy ArgStr implementation. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgStr.stories.tsx | Remove legacy ArgStr story. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgSelect.stories.tsx | Remove legacy ArgSelect story. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgNum.tsx | Remove legacy ArgNum implementation. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgInfo.tsx | Remove legacy ArgInfo implementation. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgColor.tsx | Remove legacy ArgColor implementation. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgColor.stories.tsx | Remove legacy ArgColor story. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgChar.tsx | Remove legacy ArgChar implementation. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgBool.tsx | Remove legacy ArgBool implementation. |
| packages/ui/src/4-card/ContextMenu/ArgsPane/args/ArgBool.stories.tsx | Remove legacy ArgBool story. |
| packages/ui/src/4-card/Card/types.ts | Introduce Card frame type tokens. |
| packages/ui/src/4-card/Card/index.ts | New Card barrel exports. |
| packages/ui/src/4-card/Card/context.ts | New Card context + defaults. |
| packages/ui/src/4-card/Card/CardChildren.tsx | New layout helper for card children. |
| packages/ui/src/4-card/Card/CardBody.tsx | New Card body typography/layout. |
| packages/ui/src/3-list-item/Placeholder/index.tsx | Placeholder background uses CSS var + add avatar variant. |
| packages/ui/src/2-inline-block/PillButton/index.tsx | Remove link underline decoration on hover. |
| packages/ui/src/2-inline-block/Label/index.ts | Remove legacy inline-block Label exports. |
| packages/ui/src/2-inline-block/Label/EmptyLabel.tsx | Remove legacy EmptyLabel component. |
| packages/ui/src/2-inline-block/Label/EmptyLabel.stories.tsx | Remove legacy EmptyLabel story. |
| packages/ui/src/2-inline-block/Label/AvatarLabel.tsx | Remove legacy AvatarLabel component. |
| packages/ui/src/2-inline-block/Label/AvatarLabel.stories.tsx | Remove legacy AvatarLabel story. |
| packages/ui/src/2-inline-block/InputNumber/index.tsx | Commit/clamp value on Enter in addition to blur. |
| packages/ui/src/2-inline-block/FlexibleInput/util.ts | New helper to copy computed styles. |
| packages/ui/src/2-inline-block/Checkbox/index.stories.tsx | Expand stories for null/undecided state. |
| packages/ui/src/2-inline-block/Badge/index.ts | Add Badge barrel exports. |
| packages/ui/src/2-inline-block/Badge/EmptyBadge.tsx | Add EmptyBadge component. |
| packages/ui/src/2-inline-block/Badge/constants.ts | Add badge sizing constants. |
| packages/ui/src/2-inline-block/Badge/BadgeLayout.tsx | Rename to BadgeLayout + center alignment. |
| packages/ui/src/2-inline-block/Badge/Badge.tsx | Add Badge component wrapper. |
| packages/ui/src/1-inline/Num/index.stories.tsx | Add Num stories. |
| packages/ui/src/1-inline/Label/index.tsx | Remove legacy inline Label component. |
| packages/ui/src/1-inline/Label/index.stories.ts | Remove legacy inline Label stories. |
| packages/ui/src/1-inline/Eyebrow/index.tsx | Add Eyebrow component. |
| packages/ui/src/1-inline/Eyebrow/index.stories.tsx | Add Eyebrow stories. |
| packages/ui/src/1-inline/Duration/index.stories.tsx | Add Duration stories. |
| packages/ui/src/1-inline/ColorValue/index.stories.tsx | Add ColorValue stories. |
| packages/ui/src/1-inline/ColorPreview/index.stories.tsx | Add ColorPreview stories. |
| packages/ui/src/1-inline/Bytes/index.tsx | Refactor Bytes to reuse Num renderer. |
| packages/ui/src/1-inline/Avatar/index.stories.ts | Remove legacy Avatar story. |
| packages/ui/package.json | Bump deps (iconista/thingies/very-small-parser). |
| packages/rpc-server/src/uws/util.ts | Document known uWS CORS defect. |
| packages/rpc-server/src/http1/RpcServer.ts | Delegate CORS to Http1Server with options. |
| packages/rpc-server/src/http1/index.ts | Export Http1Cors. |
| packages/rpc-server/src/tests/e2e/demo-client.ts | Use RpcBinBatchCodec for FetchCaller. |
| packages/rpc-server/src/tests/e2e/clients.ts | Use RpcBinBatchCodec for FetchCaller. |
| packages/rpc-server/package.json | Bump thingies. |
| packages/rpc-codec/src/RpcBinBatchCodec.ts | Add BinBatchCodec adapter for RpcCodec. |
| packages/rpc-codec/src/index.ts | Export RpcBinBatchCodec. |
| packages/rpc-codec/docs/text.md | Docs wording update for batch codecs. |
| packages/rpc-codec/docs/index.ts | Rename/slug “Batch codecs” docs section. |
| packages/rpc-codec/docs/compact-batch.md | Document RpcBinBatchCodec usage. |
| packages/rpc-client/src/createFetchClient.ts | Add HTTP fetch client factory. |
| packages/rpc-client/docs/text.md | Update docs for 4 factories incl. fetch client. |
| packages/rpc-client/docs/index.ts | Update docs subtitle for new factory. |
| packages/rpc-calls/package.json | Bump thingies. |
| packages/peritext/src/editor/inline/spans/col/index.tsx | Mark formatting behaviors compact. |
| packages/peritext/src/editor/inline/spans/bg/index.tsx | Mark formatting behaviors compact. |
| packages/peritext/src/editor/inline/spans/a/index.tsx | Mark formatting behaviors compact. |
| packages/peritext/src/editor/inline/spans/a/components/Edit.tsx | Migrate collaborative imports to workspace packages. |
| packages/peritext/package.json | Add collaborative-* workspace deps + bump thingies. |
| packages/nano-theme/package.json | Bump thingies. |
| packages/keyboard/package.json | Bump thingies. |
| packages/json-type/src/type/tests/getJsonSchema.spec.ts | Add tuple→JSON Schema tests. |
| packages/json-type/src/schema/schema.ts | Deprecate metadata field in schema base. |
| packages/json-type/package.json | Bump thingies. |
| packages/json-pack/src/rm/RmRecordEncoder.ts | Fix record framing offsets for writer slices. |
| packages/json-pack/src/rm/tests/RmRecordEncoder.spec.ts | Add tests for start/end record framing. |
| packages/json-pack/src/nfs/v4/server/types.ts | Remove NFSv4 server types. |
| packages/json-pack/src/nfs/v4/server/operations/OpenOwnerState.ts | Remove NFSv4 server operation state. |
| packages/json-pack/src/nfs/v4/server/operations/node/util.ts | Remove NFSv4 node util. |
| packages/json-pack/src/nfs/v4/server/operations/node/tests/READLINK.spec.ts | Remove NFSv4 READLINK test. |
| packages/json-pack/src/nfs/v4/server/operations/node/tests/OPENATTR.spec.ts | Remove NFSv4 OPENATTR test. |
| packages/json-pack/src/nfs/v4/server/operations/LockStateid.ts | Remove NFSv4 lock stateid. |
| packages/json-pack/src/nfs/v4/server/operations/LockOwnerState.ts | Remove NFSv4 lock owner state. |
| packages/json-pack/src/nfs/v4/server/operations/FilesystemStats.ts | Remove NFSv4 filesystem stats. |
| packages/json-pack/src/nfs/v4/server/demos/test-demo.sh | Remove NFSv4 demo script. |
| packages/json-pack/src/nfs/v4/server/demos/tcp-server.ts | Remove NFSv4 demo server. |
| packages/json-pack/src/nfs/v4/Nfsv4Encoder.ts | Remove NFSv4 encoder. |
| packages/json-pack/src/nfs/v4/index.ts | Remove NFSv4 exports. |
| packages/json-pack/src/nfs/v4/errors.ts | Remove NFSv4 error types. |
| packages/json-pack/src/nfs/v4/client/types.ts | Remove NFSv4 client types. |
| packages/json-pack/src/nfs/v4/client/NfsFsStats.ts | Remove NFSv4 stats wrapper. |
| packages/json-pack/src/nfs/v4/client/NfsFsDirent.ts | Remove NFSv4 dirent wrapper. |
| packages/json-pack/src/nfs/README.md | Remove outdated NFSv4 RFC link. |
| packages/json-pack/src/json/JsonDecoderPartial.ts | Token reading micro-optimizations in partial decoder. |
| packages/json-pack/src/cbor/constants.ts | Add EOF decode error constant. |
| packages/json-pack/src/cbor/CborEncoderFast.ts | Document writeTkn constraints. |
| packages/json-pack/src/cbor/CborEncoder.ts | Improve JsonPackValue handling + plain-object fast path. |
| packages/json-pack/src/bench/bench.writer-size.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.ubjson.encoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.ubjson.decoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.slice.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.shallow-read.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.resp.encoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.resp.decoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.msgpack.encoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.msgpack.decoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.json.encoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.json.decoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.ion.encoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.encoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.encoding.cbor.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.encoders.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.cbor.encoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.cbor.decoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.cbor-dag.encoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/src/bench/bench.bson.encoding.ts | Switch benches to shared util benchmark runner. |
| packages/json-pack/package.json | Bump thingies. |
| packages/json-joy/src/json-stable/bench/bench.ts | Switch bench to shared util benchmark runner. |
| packages/json-joy/src/json-patch-diff/tests/JsonPatchDiff-performance.spec.ts | Gate slow perf sizes via RUN_SLOW_TESTS. |
| packages/json-joy/src/json-crdt/nodes/obj/ObjNode.ts | Add visible key enumeration helper. |
| packages/json-joy/src/json-crdt/model/api/nodes.ts | Expose ObjApi.keys() wrapper. |
| packages/json-joy/src/json-crdt/model/api/events.ts | Add ChangeEvent.paths() helper. |
| packages/json-joy/src/json-crdt/model/api/tests/ModelApi.events.spec.ts | Add tests for ChangeEvent.paths(). |
| packages/json-joy/src/json-crdt/model/tests/pathTo.spec.ts | Add tests for path resolution. |
| packages/json-joy/src/json-crdt/bench/bench.codecs.encoding.ts | Use shared util benchmark runner. |
| packages/json-joy/src/json-crdt/bench/bench.codecs.encoding.libs.ts | Use shared util benchmark runner. |
| packages/json-joy/src/json-crdt/bench/bench.codecs.encoding.json.ts | Use shared util benchmark runner. |
| packages/json-joy/src/json-crdt/bench/bench.codecs.decoding.ts | Use shared util benchmark runner. |
| packages/json-joy/src/json-crdt-patch/codec/tests/json.fuzzer.spec.ts | Gate fuzz rounds via RUN_SLOW_TESTS. |
| packages/json-joy/src/json-crdt-patch/bench/bench.encoding.ts | Use shared util benchmark runner. |
| packages/json-joy/src/json-crdt-extensions/peritext/rga/Point.ts | Add Point DTO serialization helpers. |
| packages/json-joy/src/json-crdt-extensions/peritext/editor/types.ts | Add PointDto type + EditorPosition expands. |
| packages/json-joy/src/json-crdt-extensions/peritext/editor/Editor.ts | Support PointDto conversion in editor. |
| packages/json-joy/package.json | Bump deps and drop old collaborative deps. |
| packages/json-expression/src/operators/arithmetic.ts | Fix pow codegen operand bug. |
| packages/json-crdt/tsconfig.json | Add new json-crdt package TS config. |
| packages/json-crdt/tsconfig.build.json | Add new json-crdt build TS config. |
| packages/json-crdt/src/index.ts | Stub index export for new package. |
| packages/json-crdt/SECURITY.md | Add security policy for new package. |
| packages/json-crdt/README.md | Add readme for new package. |
| packages/json-crdt-server/src/tests/e2e/public-server/client.ts | Use RpcBinBatchCodec for FetchCaller. |
| packages/json-crdt-server/src/tests/e2e/clients.ts | Use RpcBinBatchCodec for FetchCaller. |
| packages/json-crdt-server/scripts/deploy.sh | Add post-deploy ping + CORS smoke test. |
| packages/json-crdt-server/package.json | Bump thingies. |
| packages/json-crdt-repo/src/tests/e2e/demo-client.ts | Use RpcBinBatchCodec for FetchCaller. |
| packages/json-crdt-repo/src/tests/e2e/clients.ts | Use RpcBinBatchCodec for FetchCaller. |
| packages/json-crdt-repo/package.json | Bump thingies. |
| packages/json-crdt-explorer/src/components/Menu/PwaInstallButton.tsx | Switch Label→Pill. |
| packages/json-crdt-explorer/src/components/Menu/index.tsx | Switch Label→Pill. |
| packages/diff/src/index.ts | Expand public surface exports. |
| packages/diff/src/format/tabs.ts | Add tab-expansion support for format writers. |
| packages/diff/src/format/index.ts | Add format module barrel exports. |
| packages/diff/src/format/flags.ts | Add format flag helpers. |
| packages/diff/src/format/colors.ts | Add palette painting helper. |
| packages/diff/src/bin.ts | Adjust binary apply callback signatures. |
| packages/diff/src/tests/str-fuzz.spec.ts | Fix caret semantics + add surrogate test. |
| packages/diff/src/tests/rnd.ts | Add seeded PRNG for fuzzing. |
| packages/diff/src/tests/index.spec.ts | Validate new index surface exports. |
| packages/collaborative-ui/src/StrAdapterNative/index.ts | Move imports to new collaborative-str package. |
| packages/collaborative-ui/src/StrAdapterNative/index.stories.tsx | Update imports/order after migration. |
| packages/collaborative-ui/src/StrAdapter/index.ts | Move imports to new collaborative-str package. |
| packages/collaborative-ui/src/examples/Blogpost/Tags.tsx | Switch Label→Pill. |
| packages/collaborative-ui/src/DemoDisplay/CodeMirrorEditor.tsx | Move CollaborativeStr import to collaborative-str. |
| packages/collaborative-ui/src/CollaborativeFlexibleInput/index.stories.tsx | Import ordering normalization. |
| packages/collaborative-ui/package.json | Bump thingies. |
| packages/collaborative-react/package.json | Bump thingies. |
| packages/collaborative-presence/package.json | Bump thingies. |
| packages/click-type/tsconfig.json | Add new click-type package TS config. |
| packages/click-type/tsconfig.build.json | Add new click-type build TS config. |
| packages/click-type/src/TypeInline.tsx | Add inline type preview component. |
| packages/click-type/src/Md.tsx | Add inline Markdown renderer wrapper. |
| packages/click-type/src/kinds/TypeOr.tsx | Add OR kind renderer. |
| packages/click-type/src/kinds/TypeObj.tsx | Add object kind renderer. |
| packages/click-type/src/kinds/TypeModule.tsx | Add module kind renderer. |
| packages/click-type/src/kinds/TypeMap.tsx | Add map kind renderer. |
| packages/click-type/src/kinds/TypeKey.tsx | Add key kind renderer. |
| packages/click-type/src/kinds/TypeFn.tsx | Add function kind renderer. |
| packages/click-type/src/kinds/TypeBin.tsx | Add binary kind renderer. |
| packages/click-type/src/css.ts | Add click-type CSS vars + shared rules. |
| packages/click-type/src/converters/typescript.ts | Add schema→TypeScript converter wrapper. |
| packages/click-type/src/converters/sample.ts | Add schema→sample generator wrapper. |
| packages/click-type/src/converters/jtd.ts | Add schema→JTD converter wrapper. |
| packages/click-type/src/converters/jsonSchema.ts | Add schema→JSON Schema converter wrapper. |
| packages/click-type/src/CollapseToggle.tsx | Add tree collapse toggle control. |
| packages/click-type/SECURITY.md | Add security policy for new package. |
| packages/click-type/README.md | Add readme/usage for new package. |
| packages/click-json/src/Root/index.tsx | Allow passing extra root styles (e.g. CSS vars). |
| packages/click-json/src/ObjectLayout/index.tsx | Import ordering normalization. |
| packages/click-json/src/inserts/ObjectInsert.tsx | Add openSignal to programmatically open editor. |
| packages/click-json/src/inserts/ArrayInsert.tsx | Add openSignal to programmatically open editor. |
| packages/click-json/src/ClickableJson/ValueInput.tsx | Add pointer-based focus request subscription. |
| packages/click-json/src/ClickableJson/JsonValue.tsx | Plumb pointer to ValueInput. |
| packages/click-json/src/ClickableJson/JsonProperty.tsx | Add pointer-based focus request subscription. |
| packages/click-json/src/ClickableJson/JsonObjectInsert.tsx | Wire toolbar “insert” request to openSignal. |
| packages/click-json/src/ClickableJson/JsonArrayInsert.tsx | Wire toolbar “insert” request to openSignal. |
| packages/channel/package.json | Bump thingies devDependency. |
| packages/buffers/src/types.ts | Add Reader size() API to interface. |
| packages/buffers/src/toStr.ts | Add UTF-8 buffer→string helper. |
| packages/buffers/src/bench/bench.encodeUtf8.ts | Use shared util benchmark runner. |
| packages/buffers/src/bench/bench.decodeUtf8.ts | Use shared util benchmark runner. |
| .storybook/main.ts | Add click-type + diff + json-type aliases to Storybook. |
Review details
- Files reviewed: 212/573 changed files
- Comments generated: 6
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1606
to
+1610
| if (Array.isArray(at)){ | ||
| const [a, b] = at; | ||
| if (b > 1) return Point.fromDto(this.txt.str, at as PointDto); | ||
| else return txt.pointAt(a, b); | ||
| } |
Comment on lines
+1
to
+5
| // TODO: package.json declares none of `@jsonjoy.com/buffers`, `json-pack`, | ||
| // `rpc-codec-binary` or `rpc-codec-compact`. | ||
| import {Writer} from '@jsonjoy.com/buffers/lib/Writer'; | ||
| import {CborJsonValueCodec} from '@jsonjoy.com/json-pack/lib/codecs/cbor'; | ||
| import {FetchCaller} from '@jsonjoy.com/rpc-calls/lib/caller/FetchCaller'; |
Comment on lines
42
to
45
| public readArr(): unknown[] { | ||
| const reader = this.reader; | ||
| if (reader.u8() !== 0x5b /* [ */) throw new Error('Invalid JSON'); | ||
| if (reader.uint8[reader.x++] !== 0x5b /* [ */) throw new Error('Invalid JSON'); | ||
| const arr: unknown[] = []; |
Comment on lines
17
to
21
| export const ToolbarItem: React.FC<ToolbarItemProps> = ({narrow, small, outline, autowidth, tooltip, ...rest}) => { | ||
| const size = small ? 28 : 32; | ||
| const size = small ? 24 : 32; | ||
|
|
||
| let element: React.ReactNode = ( | ||
| <BasicButton skewed width={autowidth ? 'auto' : narrow ? 20 : size} height={size} border={outline} {...rest} /> |
| @@ -11,7 +11,7 @@ const className = rule( | |||
| w: '32px', | |||
| h: '32px', | |||
| bdrad: '3px', | |||
| cur: 'pointer', | |||
| // cur: 'pointer', | |||
| @@ -4,8 +4,10 @@ import {Fonts} from './font/Fonts'; | |||
| import {theme as ltheme} from './theme/light'; | |||
| import {theme as dtheme} from './theme/dark'; | |||
| import {HslColor, ThemeColor} from './color'; | |||
| import {easing, TEasing} from './easing'; | |||
streamich
force-pushed
the
feat/monorepo-sync
branch
from
September 7, 2026 23:19
f7ebab1 to
fa62097
Compare
streamich
force-pushed
the
feat/monorepo-sync
branch
from
September 7, 2026 23:34
fa62097 to
dbc68bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.