Log tier1 client disconnects as Canceled, not Unknown

[sduchesneau]

Problem

Client disconnects on a tier1 Blocks stream (context canceled) are logged noisily at WARNING and ERROR:

severity: WARNING  message: "Blocks request completed with error"  error: "canceled: context canceled"
severity: ERROR    message: "finished streaming call with code Unknown"  grpc.code: "Unknown"  error: "canceled: context canceled"

Root cause

toGrpcTier1Error (service/error.go) returns a connect error for the context-canceled case:

return connect.NewError(connect.CodeCanceled, err)

Every other branch in that function returns a gRPC status.Error(codes.X, ...). The caller in service_grpc.go then does status.Code(grpcErr) — and status.Code() on a connect error (not a gRPC status) returns codes.Unknown. So:

• service_grpc.go falls through to default → logger.Warn("Blocks request completed with error") instead of the codes.Canceled case (Debug).
• The gRPC logging middleware sees code Unknown → logs the finished call at ERROR (grpc_zap maps Unknown→Error, Canceled→Info).

Fix

Return a gRPC status error for the canceled branch, consistent with the rest of the function:

return status.Error(codes.Canceled, err.Error())

Now status.Code() resolves to codes.Canceled: service_grpc.go logs at Debug ("Blocks request canceled by user"), and the middleware logs the call at Info. The connect path (toConnectError) already handled this correctly and is unchanged.

🤖 Generated with Claude Code

[sduchesneau]

🔍 Vulnerabilities of ghcr.io/streamingfast/substreams:0bc218a

📦 Image Reference ghcr.io/streamingfast/substreams:0bc218a

digest	sha256:12fb2903c4ae827cf35c81601b8d3a45147d4851b08e69f9f2889276e23735fb
vulnerabilities
platform	linux/amd64
size	109 MB
packages	353

📦 Base Image ubuntu:24.04

also known as	noble noble-20260610
digest	sha256:52df9b1ee71626e0088f7d400d5c6b5f7bb916f8f0c82b474289a4ece6cf3faf
vulnerabilities