Fix ImportError in kg_emb caused by SampleBaseDataset rename#1140
Open
MadhukarJukanti wants to merge 1 commit intosunlabuiuc:masterfrom
Open
Fix ImportError in kg_emb caused by SampleBaseDataset rename#1140MadhukarJukanti wants to merge 1 commit intosunlabuiuc:masterfrom
MadhukarJukanti wants to merge 1 commit intosunlabuiuc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #952.
SampleBaseDatasetwas renamed toSampleDatasetduring the PyHealth 2.0upgrade, but 7 files in the
kg_embmodule were never updated. Any userimporting from
pyhealth.medcode.pretrained_embeddings.kg_embhit animmediate
ImportErrorbecauseSampleBaseDatasetno longer exists inpyhealth.datasets.Updated all imports and type annotations across the affected files:
datasets/sample_kg_dataset.pydatasets/splitter.pymodels/kg_base.pymodels/complex.pymodels/distmult.pymodels/rotate.pymodels/transe.pyTest plan
from pyhealth.medcode.pretrained_embeddings.kg_emb.datasets import SampleKGDatasetno longer raisesImportErrorfrom pyhealth.medcode.pretrained_embeddings.kg_emb.models import ComplEx, DistMult, RotatE, TransEnolonger raises
ImportErrorAnd a short commit message (no body needed since the PR description covers it):
fix: update kg_emb imports from SampleBaseDataset to SampleDataset