Skip to content

refactor(cli): cover the api, http and auth modules with effect lint (CLI-2649) - #7084

Merged
7ttp merged 2 commits into
developfrom
7ttp/cli-2649-api-http-auth-modules-coverage
Oct 12, 2026
Merged

7ttp merged 2 commits into
developfrom
7ttp/cli-2649-api-http-auth-modules-coverage

Conversation

@7ttp

@7ttp 7ttp commented Oct 10, 2026

Copy link
Copy Markdown
Member

TL;DR

brings the api, http and auth modules under the effect lint,
along with profile, debug and the rest of project

whats introduced?

  • the files of these modules join the allow list
  • dohFetch runs as one effect, and the request signal still only cancels the DoH lookup, so responses and fetch errors come back as before
  • identity-stitch writes telemetry.json through a schema codec and DateTime with the same bytes, a raw int64 schema_version included
  • the --debug HTTP timestamp and the default login token name read the clock through Effect, and the branch resolvers move to Effect.fn with the same span names
  • tests move to scoped temp dirs, TestClock and it.effect, with new cases for the abort handling, the int64 token, the debug timestamp and the token name

ref

@7ttp 7ttp self-assigned this Oct 10, 2026
@7ttp
7ttp requested a review from a team as a code owner October 10, 2026 16:21

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews were available. Claude's sole finding is confirmed as a nonblocking test-organization nit; Codex reported no findings. Adjudication used code inspection; tests were not executed.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli/src/commands/login/login.integration.test.ts:210 test-organization claude The default-token-name test exercises loginCryptoLayer directly but is placed in the login command's integration suite.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread apps/cli/src/commands/login/login.integration.test.ts
@7ttp
7ttp enabled auto-merge October 12, 2026 09:43
@7ttp
7ttp added this pull request to the merge queue Oct 12, 2026
Merged via the queue into develop with commit c4b866a Oct 12, 2026
29 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2649-api-http-auth-modules-coverage branch October 12, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants