Skip to content

feat(cli)!: remove db remote commit and the low-use inspect db aliases - #7109

Merged
Coly010 merged 3 commits into
nextfrom
columferry/cli-2595-bc-remove-deprecated-legacy-commands-db-remote-commit-and
Oct 13, 2026
Merged

Coly010 merged 3 commits into
nextfrom
columferry/cli-2595-bc-remove-deprecated-legacy-commands-db-remote-commit-and

Conversation

@Coly010

@Coly010 Coly010 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Summary

This removes four commands that have been deprecated for at least one stable cycle and have a direct replacement. They stay registered but are hidden from help. Running any of them now exits 1 and names the replacement. This uses the same removedCommand() tombstone as db remote changes and gen keys.

Command Replacement
db remote commit db pull
inspect db total-index-size inspect db index-stats
inspect db total-table-sizes inspect db table-stats
inspect db table-index-sizes inspect db table-stats
  • The tombstones still accept their old flags, so existing invocations reach the removal error instead of a parse error. The inspect tombstones open no DB connection.
  • Each tombstone records a RemovedSurfaceError telemetry fingerprint (removed_command), so remaining usage stays visible.
  • Their handlers, handler tests and per-command docs pages are deleted. SIDE_EFFECTS.md and the DOCS_EXCLUDED table are updated.
  • The pg-delta config description no longer mentions db remote commit, and config.schema.json is regenerated.
  • The higher-use inspect db aliases (table-sizes, index-sizes, cache-hit, …) are unchanged.

The matching "removed in v3" warning text for stable is in #7108 (develop).

Linked issue

Part of CLI-2595

Checklist

  • The PR title follows Conventional Commits.
  • Tests added or updated: hidden-flag.unit.test.ts runs all four tombstones and asserts the removal message and suggestion, and checks they're absent from inspect db --help.
  • From the repository root, pnpm check:all passes.

🤖 Generated with Claude Code

BREAKING CHANGE: supabase db remote commit is removed; use supabase db pull. supabase inspect db total-index-size is removed; use supabase inspect db index-stats. supabase inspect db total-table-sizes and supabase inspect db table-index-sizes are removed; use supabase inspect db table-stats. Each removed command exits 1 and prints its replacement.

`db remote commit`, `inspect db total-index-size`, `inspect db total-table-sizes`
and `inspect db table-index-sizes` now exit 1 and name their replacement.

BREAKING CHANGE: `supabase db remote commit` is removed (use `supabase db pull`), and
`supabase inspect db total-index-size` (use `index-stats`), `total-table-sizes` and
`table-index-sizes` (use `table-stats`) are removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Coly010 Coly010 self-assigned this Oct 13, 2026
@Coly010

Coly010 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Confirmed both Claude findings as non-blocking nits: an unused pull option and a stale command count. Codex reported no findings. Inspection of the checked-out code found no additional concrete issues. Tests were not run.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli/src/commands/db/pull/pull.handler.ts:50 dead-code claude The skipFinishedLine option is obsolete after removal of the db remote commit handler; no remaining caller sets it.
⚪ NIT apps/cli/src/commands/inspect/db/inspect-db-command.ts:37 documentation claude The inspectDbCommandHandler JSDoc still says it is shared by all 25 command files, but only 22 use it after the three aliases become tombstones.

Findings outside the diff

  • ⚪ NIT apps/cli/src/commands/db/pull/pull.handler.ts:50 — The skipFinishedLine option is obsolete after removal of the db remote commit handler; no remaining caller sets it.
  • ⚪ NIT apps/cli/src/commands/inspect/db/inspect-db-command.ts:37 — The inspectDbCommandHandler JSDoc still says it is shared by all 25 command files, but only 22 use it after the three aliases become tombstones.

Stats

Claude findings: 2 · Codex findings: 0 · Confirmed: 2 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Coly010
Coly010 marked this pull request as ready for review October 13, 2026 09:27
@Coly010
Coly010 requested a review from a team as a code owner October 13, 2026 09:27
Comment thread apps/cli/src/commands/db/remote/commit/SIDE_EFFECTS.md Outdated
Comment thread apps/cli/src/shared/cli/hidden-flag.unit.test.ts Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Coly010
Coly010 added this pull request to the merge queue Oct 13, 2026
Merged via the queue into next with commit 948107b Oct 13, 2026
38 checks passed
@Coly010
Coly010 deleted the columferry/cli-2595-bc-remove-deprecated-legacy-commands-db-remote-commit-and branch October 13, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants