Skip to content

fix(deploy): preserve resolved image digest for Machines#5010

Open
ruizkinio wants to merge 1 commit into
superfly:masterfrom
ruizkinio:fix/preserve-deploy-image-digest-upstream
Open

fix(deploy): preserve resolved image digest for Machines#5010
ruizkinio wants to merge 1 commit into
superfly:masterfrom
ruizkinio:fix/preserve-deploy-image-digest-upstream

Conversation

@ruizkinio

Copy link
Copy Markdown

What changed

  • Preserve the resolved tag@sha256 reference when constructing Machine deployment arguments and deployment status.
  • Assert the immutable reference on every app Machine created by the deploy command.
  • Assert the same immutable reference on new and reused release-command Machine configs.

Why

Image resolution already returns both Tag and Digest, but the deploy path passed only img.Tag. A mutable tag could therefore be resolved correctly and then used without its digest by the release command and serving Machines.

Validation

  • go test ./... -count=1
  • go vet ./internal/build/imgsrc ./internal/command/deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant