Repository navigation
Add max_run_after_disconnect exec option #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gkpacker
wants to merge
7
commits into
superfly:main
Choose a base branch
from
gkpacker:gkpacker/max_run_after_disconnect-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
054a781
Add fake WebSocket server and exec test helpers
gkpacker 6b938cf
Refactor control-mode exec args into a pipeline
gkpacker 75a8fc5
Add max_run_after_disconnect exec option
gkpacker 0398e8d
Encode extended WebSocket frame lengths in FakeWsServer
gkpacker 0fd982c
Validate max_run_after_disconnect before starting the command
gkpacker 24cc590
Document TTY-dependent default for max_run_after_disconnect
gkpacker 9e5eb38
Validate max_run_after_disconnect duration syntax
gkpacker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When control mode is selected and a non-string value is passed,
Control.checkout/1has already markedconn_pidbusy before this validation raises. The init process then exits beforeControlConn.start_op/4and never executesControl.checkin/2, so the still-live connection remains marked busy; repeated rejected spawns consume sockets and can fill the 100-slot pool, forcing later valid control commands down the direct fallback. Validate before checkout or check the connection back in on this failure path.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed in 0fd982c: the option is now validated in
Command.start/4before the GenServer starts, so no checkout happens and callers get anArgumentErrordirectly; the test asserts neither transport is contacted.