Repository navigation
Accept any 2xx when updating a network policy - #42
Merged
aezell merged 1 commit intoOct 29, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
gkpacker
force-pushed
the
gkpacker/sprites-network-policy-2xx-pr
branch
2 times, most recently
from
October 17, 2026 14:52
f99e87c to
6ca54b8
Compare
gkpacker
added a commit
to gkpacker/sprites-ex
that referenced
this pull request
Oct 17, 2026
…ect (superfly#41) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gkpacker
force-pushed
the
gkpacker/sprites-network-policy-2xx-pr
branch
from
October 17, 2026 14:55
6ca54b8 to
cc2fe3f
Compare
gkpacker
added a commit
to gkpacker/sprites-ex
that referenced
this pull request
Oct 17, 2026
…ect (superfly#41) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gkpacker
force-pushed
the
gkpacker/sprites-network-policy-2xx-pr
branch
from
October 17, 2026 14:56
cc2fe3f to
e73be58
Compare
gkpacker
added a commit
to gkpacker/sprites-ex
that referenced
this pull request
Oct 17, 2026
…ect (superfly#41) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gkpacker
commented
Oct 17, 2026
| {:cowlib, "~> 2.19.0"}, | ||
| {:jason, "~> 1.4"}, | ||
| {:client_signals, "~> 0.4.4"}, | ||
| {:plug, "~> 1.0", only: :test}, |
Contributor
Author
There was a problem hiding this comment.
plug is added as a test-only dependency so the new policy tests can stub HTTP with Req.Test. Req's plug: option, Req.Test.stub/2 and Req.Test.json/2 are only compiled when Plug is available. It is only: :test, so SDK users don't pull it in. Without it, the alternative is a custom Req adapter: module in the test file.
Collaborator
|
@gkpacker This change looks good. Could you double-check the conflict? It looks like there's a newer version of |
The API returns 200 for POST /v1/sprites/{name}/policy/network, but
update_by_name/3 only treated 204 as success, so successful updates were
reported as {:error, {:api_error, 200, body}}. Match status in 200..299
like the rest of the SDK.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gkpacker
force-pushed
the
gkpacker/sprites-network-policy-2xx-pr
branch
from
October 26, 2026 17:19
e73be58 to
7013c88
Compare
gkpacker
added a commit
to gkpacker/sprites-ex
that referenced
this pull request
Oct 26, 2026
# Conflicts: # mix.lock
Contributor
Author
|
@aezell good to go now |
aezell
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The API returns 200 for
POST /v1/sprites/{name}/policy/network, butSprites.Policy.update_by_name/3(and soSprites.update_network_policy/2) only treated 204 as success. A successful update was reported as{:error, {:api_error, 200, body}}.The published OpenAPI spec (
superfly/sprites-docs/api/openapi.json) lists200(with the rules as a JSON body),400,404and500for this endpoint. It does not list 204.Fix
Change the success match to
status in 200..299. This is the same 2xx handling used everywhere else in the SDK (client.ex,filesystem.ex,Policy.get_by_name/2). Error handling for 400 and other statuses is unchanged.Tests
Added
test/policy_test.exs. HTTP is stubbed withReq.Testthrough aplug:on the client'sreq. This addsplugas a test-only dependency.:okand sends a POST to/v1/sprites/my-sprite/policy/network(this test fails without the fix):ok{:error, {:invalid_policy, body}}🤖 Generated with Claude Code