Unblock new dependency of XCTest on Swift Testing for Windows - #2760
Merged
Merged
Conversation
Update compiler args for a test to include the Testing module alongside the XCTest module. XCTest requires a Swift Testing dependency when built in the toolchain: swiftlang/swift-corelibs-xctest#549 On Windows, the test "IndexedSingleSwiftFileTestProject" manually constructs the compilation flags in a way that previously only included the XCTest module, causing a test failure in the PR that adds the Swift Testing dependency.
Contributor
Author
|
With my toolchain build I can confirm this does fix the build issue that's blocking the corelibs XCTest PR. |
Contributor
Author
|
@swift-ci Please test |
jerryjrchen
marked this pull request as ready for review
September 8, 2026 23:39
jerryjrchen
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
September 8, 2026 23:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update compiler args for a test to include the Testing module alongside the XCTest module.
XCTest requires a Swift Testing dependency when built in the toolchain: swiftlang/swift-corelibs-xctest#549
On Windows, the test "IndexedSingleSwiftFileTestProject" manually constructs the compilation flags in a way that previously only included the XCTest module, causing a test failure in the PR that adds the Swift Testing dependency.