Expose SwiftLexicalLookup to SourceKitLSP through SWIFT_SYNTAX_MODULES - #91985
Merged
Merged
Conversation
…ULES` It seems like we can’t reference `SwiftLexicalLookup` from CMake in SourceKit-LSP because it’s not in this list. `SwiftLexicalLookup` will be used by swiftlang/sourcekit-lsp#2754, so we need to expose it.
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
@swift-ci Please build toolchain Windows |
hamishknight
approved these changes
Sep 8, 2026
rintaro
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like we can’t reference
SwiftLexicalLookupfrom CMake in SourceKit-LSP because it’s not in this list.SwiftLexicalLookupwill be used by swiftlang/sourcekit-lsp#2754, so we need to expose it.