Skip to content

IPFIX Compatibility#150

Open
rselph wants to merge 4 commits into
synfinatic:mainfrom
rselph:ipfix
Open

IPFIX Compatibility#150
rselph wants to merge 4 commits into
synfinatic:mainfrom
rselph:ipfix

Conversation

@rselph

@rselph rselph commented Jan 11, 2026

Copy link
Copy Markdown

Adresses Issue #60

@rselph rselph marked this pull request as ready for review January 11, 2026 06:09
Copilot AI review requested due to automatic review settings June 19, 2026 11:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates netflow2ng to explicitly support IPFIX alongside NetFlow v9, aligning docs/config and extending ntopng output to include IPFIX-compatible fields.

Changes:

  • Update README and log messaging to refer to NetFlow v9/IPFIX support.
  • Extend ntopng TLV/JSON formatters to emit additional IPFIX fields (timestamps in ms, observation metadata, etc.) for better compatibility.
  • Add an ipfix section to the goflow2 mapping.yaml configuration and add a new Copilot project-structure doc.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Documents NetFlow v9/IPFIX support and clarifies related sections.
formatter/ntopng_tlv.go Adds IPFIX-related fields to TLV output for ntopng compatibility.
formatter/ntopng_json.go Adds the same IPFIX-related fields to JSON output.
formatter/mapping.yaml Adds IPFIX field remapping alongside the existing NetFlow v9 mapping.
cmd/netflow2ng.go Updates template-not-found log message wording to mention IPFIX.
.gitignore Adds editor/tool directories to ignore (but includes a typo to fix).
.github/copilot-instructions.md Adds repository structure and build guidance for Copilot usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,91 @@
# netflow2ng Project Structure

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really sure I want this committed... I don't use copilot for dev myself and by committing it I'm effectively now on the hook to maintain it. I assume you automatically generated this via Copilot and suggest you continue to do so.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@synfinatic agree, i have a handcfrafted implementation for IPFIX in my PR, dont sloppify netflow2ng!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants