feat: allow to search only for locations - #1608
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThe items page adds an optional ChangesLocation Filter
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant FilterPopover
participant ItemsPage
participant Router
participant ItemsAPI
FilterPopover->>ItemsPage: Toggle isLocation
ItemsPage->>Router: Update route query
ItemsPage->>ItemsAPI: Request filtered items
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/locales/pl.json`:
- Line 565: Remove the added "is_location" entry from frontend/locales/pl.json,
keeping the new translation key only in frontend/locales/en.json; do not modify
non-English locale files because Weblate manages those translations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 1dc9bc07-206a-4600-82dd-8ba56c17a78c
📒 Files selected for processing (4)
frontend/lib/api/classes/items.tsfrontend/locales/en.jsonfrontend/locales/pl.jsonfrontend/pages/items.vue
45e2272 to
d8c424e
Compare
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
This feature adds a switch to search only for locations. There is already handling in the backend, but it was never propagated.
This is useful, because now with extendable entity types, we can create stuff like boxes, which are more dynamic in their nature. Having that different entity types it's beneficial to search for them.
Which issue(s) this PR fixes:
There is no issue.