feat: add external id mode - #1627
Draft
p-garence wants to merge 13 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1404
Description
This PR introduces the External ID feature, allowing users to link physical items to pre-existing third-party QR codes or asset tags without needing to use Homebox generated labels.
This feature is completely hidden by default and must be explicitly enabled in the settings (
external_ids_enabled).Feature Workflow:
Changes Made
Backend
external_ids_enabledfield to the schema and generated the corresponding Goose migrations. It's attached to the Group object.external_idfield to the schema and generated the corresponding Goose migrations. It's attached to the Entity object.GetOneByExternalIDto retrieve items within the user's group context.GET /api/v1/entities/external/{external_id}swagannotations for the new endpoint.Frontend
getByExternalIdto the TypeScript API client.DetailsSectionto display theexternalIdif the setting is enabled.Testing and linting
Linting was returning errors on main, the changes keep the count to the same number. (did not find a way to resolve)
The tests were returning errors on main, the changes keep the count to the same number. (did not find a way to resolve)
I wanted to have some feedback on the feature before implementing the finale tests.
Is this feature in the spirit of the project ?