fix(syscoin): keep asset metadata aligned in tx lists#28
Conversation
Scope the asset-aware transaction row layout to Syscoin explorers so upstream Bitcoin-type pages keep their existing rendered markup. Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2f0a71a40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <a class="outpoint" href="/tx/{{$vin.Txid}}" tt="Outpoint {{$vin.Txid}},{{$vin.Vout}}">←</a> | ||
| {{end}} | ||
| </div> | ||
| {{if $vin.Addresses}} |
There was a problem hiding this comment.
For Syscoin inputs, this guard now hides the entire amount column, including the $vin.AssetInfo block. When an asset UTXO has an unparseable or unsupported script, the worker can still populate AssetInfo from the spent output while leaving Addresses empty, so the row regresses from showing the SPT asset metadata to only showing Unparsed address. Render this block when either addresses or asset metadata are present, or keep the asset metadata outside the address guard.
Useful? React with 👍 / 👎.
Keep Syscoin SPT input metadata visible when an input script cannot be decoded to an address but asset information is still available from the spent output. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50b6b2f537
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .tx-detail .head .txid { | ||
| float: none; | ||
| } |
There was a problem hiding this comment.
This selector is global for every transaction detail header, but the change is only needed for the new Syscoin badge layout. Because .txid still inherits display: block from the existing .tx-detail a.ellipsis rule, clearing its float makes any inline header content after the txid—most visibly the RBF marker on Bitcoin-style RBF transactions—render on a separate line instead of beside the txid. Scope this reset to Syscoin rows or to the badge case so non-Syscoin transaction headers keep their previous layout.
Useful? React with 👍 / 👎.
Remove the global transaction ID float reset so non-Syscoin headers keep their existing inline markers while Syscoin type badges still clear below the txid. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Test plan
go test -tags unittest ./server -run Test_PublicServer_BitcoinType -count=1go test -tags unittest ./bchain/coins/sys ./db ./bchain -run 'Test(Syscoin|.*Syscoin|.*AssetVersion|.*LoadAssets|BaseMempool_GetTxAssets)' -count=1git diff --check && git diff --cached --checkMade with Cursor