Conversation
Current coverage is 92.07% (diff: 100%)@@ master #38 diff @@
==========================================
Files 11 11
Lines 164 164
Methods 57 57
Messages 0 0
Branches 18 18
==========================================
Hits 151 151
Misses 0 0
Partials 13 13
|
|
|
||
| static auto readConfiguration() { | ||
| passwd *pw = getpwuid(getuid()); | ||
| std::string const configFile = std::string{pw->pw_dir} + "/.yebash.cfg"; |
There was a problem hiding this comment.
Well, for me this yebash.cfg looks too much DOS/Windows-ish ;)
There was a problem hiding this comment.
it's simple enough and does the job. do we have any alternatives?
There was a problem hiding this comment.
I mean only that the .yebash.cfg name reminds me old Windows configuration files naming convention. I would rather choose .yebashrc as it's quite Unix-ish ;) Yes, I know I'm nitpicking ;)
| add_subdirectory(test) | ||
| install(FILES bin/yebash DESTINATION bin PERMISSIONS OWNER_WRITE OWNER_READ GROUP_READ WORLD_READ OWNER_EXECUTE GROUP_EXECUTE WORLD_EXECUTE) | ||
| else() | ||
| message(FATAL "Boost not found") |
|
|
||
| add_library(${PROJECT_NAME} SHARED ${SOURCES}) | ||
| target_link_libraries(${PROJECT_NAME} -ldl) | ||
| target_link_libraries(${PROJECT_NAME} -ldl ${Boost_LIBRARIES}) |
There was a problem hiding this comment.
Property Tree is a header-only library, so you don't need to link yebash with Boost libs
There was a problem hiding this comment.
yes I know, I added it in case we will use any other Boost lib in future. i'll remove it, though
| find_package(Boost) | ||
|
|
||
| install(FILES bin/yebash DESTINATION bin PERMISSIONS OWNER_WRITE OWNER_READ GROUP_READ WORLD_READ OWNER_EXECUTE GROUP_EXECUTE WORLD_EXECUTE) | ||
| if(Boost_FOUND) |
There was a problem hiding this comment.
I would rather write if(NOT Boost_FOUND) \n message(FATAL_ERROR ...) ...
3 participants
No description provided.