Fix NLDAS-2 Data Download - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release fixes NLDAS-2 downloads failing with
403 Forbiddenerrors from the NASA Giovanni timeseries API. All download requests inget_nldas_pointwere rejected because the authentication token sent with each request was malformed.The root cause was a change on NASA's end. The previous implementation retrieved a token from the undocumented Giovanni
/signinendpoint, which originally returned the token as a bare quoted string. NASA has since changed the response to a JSON object ({"expires_in": ..., "token": ...}), so the old parsing produced a garbled token and every subsequent request returned 403. Rather than re-parsing the new response format, this release replaces the/signinflow entirely with NASA's documented authentication workflow for the Giovanni API: an Earthdata Login (EDL) bearer token retrieved viaearthaccess, per the official GES DISC tutorial. This avoids depending on an undocumented endpoint that may change again.