add CI comments related to commented-out LLVM version entries in test matrix - #196
Merged
taiki-e merged 1 commit intoNov 18, 2024
Conversation
brody2consult
marked this pull request as draft
November 15, 2024 04:10
Contributor
Author
|
I think the build failure with Rust nightly & |
Owner
|
Sorry, but I don't think it is helpful to put these not very clear descriptions for each commented out code. I this it is better to add |
brody2consult
changed the title
brody2consult
force-pushed
the
extra-llvm-version-testing-ci-comments
branch
from
November 17, 2024 02:56
7b68705 to
fd3d6c2
Compare
brody2consult
force-pushed
the
extra-llvm-version-testing-ci-comments
branch
from
November 18, 2024 03:55
fd3d6c2 to
e07531e
Compare
brody2consult
marked this pull request as ready for review
November 18, 2024 05:03
Contributor
Author
|
Rewritten & rebased please let me know if anything else is needed thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coming from this comment: #195 (comment)
If we need some more info in these comments, I would appreciate any pointers to what LLVM issue(s) this is related to.