Skip to content

ui/users: show hidden private contact methods - #4616

Open
weefatboi wants to merge 3 commits into
masterfrom
fix/show-hidden-private-contact-methods
Open

weefatboi wants to merge 3 commits into
masterfrom
fix/show-hidden-private-contact-methods

Conversation

@weefatboi

@weefatboi weefatboi commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor
  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
When you view another user's profile, their private contact methods are left out of the Contact Methods list, so a user whose only contact methods are private shows "No contact methods". Their notification rules still show up, as "notify me via PRIVATE", so the two cards seem to disagree, and it reads like the user can't be reached.

Now, when one of the user's notification rules points at a contact method the viewer can't see, the Contact Methods card says "This user has one or more private contact methods". It replaces "No contact methods" when nothing else is listed, and shows as a note above the list when the user also has visible contact methods. Rules only show that a private method exists, not how many, so it doesn't try to count or list them. It uses the contactMethodID already exposed on UserNotificationRule, so there's no API or backend change. The owner's own view is unchanged.

Which issue(s) this PR fixes:
None filed. Found while reviewing on-call readiness for users with private contact methods.

Out of Scope:
Exposing a hidden contact method's type or status. That stays private by design.

Screenshots:
Screenshot 2026-11-20 at 15 48 27
Screenshot 2026-11-20 at 15 48 31

Describe any introduced user-facing changes:
Viewing another user's profile shows "This user has one or more private contact methods" when their notification rules use a private contact method. It takes the place of "No contact methods" when nothing else is listed, and appears above their visible contact methods otherwise.

Describe any introduced API changes:
None.

Additional Info:
Added two stories. HiddenPrivateContactMethod checks that a user with only hidden private contact methods shows the note instead of "No contact methods". VisibleAndHiddenPrivateContactMethods checks that a user with a visible and a hidden contact method lists the visible one and shows the note once.

Signed-off-by: Gordon Wall <19763395+weefatboi@users.noreply.github.com>
@weefatboi weefatboi self-assigned this Oct 31, 2026
@weefatboi
weefatboi requested a review from KatieMSB October 31, 2026 02:05
@github-actions github-actions Bot added size/m and removed size/s labels Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants