Repository navigation
Conversation
Signed-off-by: Gordon Wall <19763395+weefatboi@users.noreply.github.com>
mastercactapus
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
When you view another user's profile, their private contact methods are left out of the Contact Methods list, so a user whose only contact methods are private shows "No contact methods". Their notification rules still show up, as "notify me via PRIVATE", so the two cards seem to disagree, and it reads like the user can't be reached.
Now, when one of the user's notification rules points at a contact method the viewer can't see, the Contact Methods card says "This user has one or more private contact methods". It replaces "No contact methods" when nothing else is listed, and shows as a note above the list when the user also has visible contact methods. Rules only show that a private method exists, not how many, so it doesn't try to count or list them. It uses the
contactMethodIDalready exposed onUserNotificationRule, so there's no API or backend change. The owner's own view is unchanged.Which issue(s) this PR fixes:
None filed. Found while reviewing on-call readiness for users with private contact methods.
Out of Scope:
Exposing a hidden contact method's type or status. That stays private by design.
Screenshots:


Describe any introduced user-facing changes:
Viewing another user's profile shows "This user has one or more private contact methods" when their notification rules use a private contact method. It takes the place of "No contact methods" when nothing else is listed, and appears above their visible contact methods otherwise.
Describe any introduced API changes:
None.
Additional Info:
Added two stories.
HiddenPrivateContactMethodchecks that a user with only hidden private contact methods shows the note instead of "No contact methods".VisibleAndHiddenPrivateContactMethodschecks that a user with a visible and a hidden contact method lists the visible one and shows the note once.