Repository navigation
GoAlert: bump go-jose v3 and v4 (6 Dependabot alerts) - #4635
Open
CameronJHall wants to merge 1 commit into
Open
CameronJHall wants to merge 1 commit into
CameronJHall wants to merge 1 commit into
Conversation
mockoidc was the only module requiring github.com/go-jose/go-jose/v3, which has no patched release for Dependabot alerts #130, #133 and #134. Its latest commit (e06ed0b7cb7f) moved to go-jose/v4, so go mod tidy removes v3 entirely. Minimal version selection also raises go-jose/v4 from v4.1.4 to v4.1.8 (above v4.1.6, the fix for #131, #135 and #136), stretchr/testify from v1.11.1 to v1.12.1, and go.yaml.in/yaml/v3 from v3.0.4 to v3.0.5, all required by the new mockoidc. Signed-off-by: CameronJHall <cjhall1283@gmail.com>
CameronJHall
marked this pull request as ready for review
November 20, 2026 16:42
KatieMSB
approved these changes
Nov 20, 2026
mastercactapus
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot reports six alerts against
github.com/go-jose/go-josev3 and v4: a DoS when parsing RSA JWKs, panics in JSON parsing, and a panic in CBC-HMAC processing. There is no patched v3 release (every version up to 3.0.5 is affected), so v3 has to go. Its only user isoauth2-proxy/mockoidc, the dev/test OIDC server behindgo tool mockoidc. Upstream mockoidc now uses go-jose v4, so bumping it removes v3 and also raises v4, which production OIDC login uses through go-oidc, to the patched 4.1.8.What changed
go.mod/go.sum: bumpgithub.com/oauth2-proxy/mockoidctov0.0.0-20261103160011-e06ed0b7cb7f, upstream's latest commit, which imports go-jose/v4 instead of v3.go mod tidythen dropsgo-jose/v3 v3.0.5.go-jose/v4from 4.1.4 to 4.1.8 (the fixes landed in 4.1.5 and 4.1.6),stretchr/testifyfrom 1.11.1 to 1.12.1 andgo.yaml.in/yaml/v3from 3.0.4 to 3.0.5, all required by the new mockoidc.devtools/mockoidc/main.gobuilds unchanged against the new version.Checks run
grep go-jose/v3 go.mod go.sum; go mod why -m github.com/go-jose/go-jose/v3; go mod graph | grep go-jose(no v3 matches; 'main module does not need module github.com/go-jose/go-jose/v3'; graph shows only go-jose/v4@v4.1.8): v3 is fully removed from the module graph, and v4 resolves to 4.1.8curl POST https://api.osv.dev/v1/query for go-jose/v4 4.1.4 and 4.1.8, and v3 3.0.5; GET /v1/vulns for the 3 GHSAs(4.1.8: no vulns. 4.1.4 and 3.0.5: GHSA-4w3g-jfj2-cw2q, GHSA-mgcc-cww5-fp2q, GHSA-vvm8-gf78-28g4. Fixed in v4 4.1.5/4.1.6; v3 last affected 3.0.5): the resolved versions clear all three advisories behind the six alertsgo build ./... && go vet ./devtools/mockoidc/ ./auth/oidc/...(exit 0): mockoidc main.go and the production OIDC code compile against the new modulesgo mod tidy && git diff --exit-code go.mod go.sum(no diff): go.mod and go.sum are tidy, as make check-go requiresGOTOOLCHAIN=go1.26.0 make generate(exit 0, no diff): the generated code the dep-autoapprove workflow would regenerate is unchangedGOTOOLCHAIN=go1.26.0 golangci-lint run (v2.12.2, built from source into $TMPDIR)(0 issues, exit 0): the lint half of make check-goZONEINFO=$(go env GOROOT)/lib/time/zoneinfo.zip go test -short ./...(exit 0. Without ZONEINFO, 3 *_MidnightDST tests fail, and fail the same way on master): the Go half of make test, including the testify 1.12.1 bumpbin/tools/bun test web (make test's jest step), on this branch and on a master copy(152 pass, 3 fail on both (formatTimestamp x2, mapOverrideUserError)): the JS unit tests are unaffected; web/ and bun.lock are identical to masterbuilt devtools/mockoidc, ran it with -addr=127.0.0.1:19997, and curled the discovery and JWKS endpoints(issuer http://127.0.0.1:19997/oidc; one RS256 RSA key in the JWKS): the new mockoidc still serves the endpoints GoAlert discoversgo run of a throwaway program in $TMPDIR using go-oidc v3.19.0 and go-jose v4.1.8 against that mock(login OK for both redirect hosts (localhost:6130 and 127.0.0.1:6120); nonce matched; preferred_username=jane.doe; reused code and wrong secret rejected): the same code exchange, id_token check, nonce check and userinfo lookup that auth/oidc doesGOTOOLCHAIN=go1.26.0 make reset-integration, then env -u CI bin/tools/bun run playwright test test/integration/oidc.spec.ts(4 passed (2 tests x chromium-wide/mobile)): real GoAlert login throughgo tool mockoidcend to endbin/tools/bun run check && make web/src/build/static/app.js(both exit 0): the repo's test command and the bundle build the repo notes ask for on dependency bumpsbin/tools/bun run check: passed. The repo's test command, run by Cambot on the finished branch.Drafted by Cambot for task “GoAlert: bump go-jose v3 and v4 (6 Dependabot alerts)”.
Cambot-Task: 77