fix: repair Cloudflare Pages deploy + make CI mirror the real build - #192
Merged
Conversation
The site (rfc.tari.com) is published by the Cloudflare Pages 'rfcs' project, not GitHub Pages. Between #175 and now it silently froze: #175 removed build.js while the Cloudflare build command still ran 'node build.js', and CI built a different way so nothing went red. - Add scripts/build.sh as the single build recipe (pins mdBook 0.5.2 + mdbook-mermaid 0.17.0). Cloudflare Pages build command is now 'bash scripts/build.sh'. - Repoint both workflows at the same script so CI fails when the real build would fail. rfc_deploy.yml no longer pushes to the dead gh-pages branch; it just verifies the build. Bump checkout v2.3.1 -> v4. - Add DEPLOYMENT.md documenting the real pipeline.
Deploying rfcs with
|
| Latest commit: |
1d4a7fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf6a842a.rfcs-6p3.pages.dev |
| Branch Preview URL: | https://fix-cloudflare-pages-deploy.rfcs-6p3.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
rfc.tari.com is published by the Cloudflare Pages 'rfcs' project, not GitHub Pages. It silently froze from 2026-06-17 to 2026-07-29: PR #175 removed
build.js, but the Cloudflare build command still rannode build.js, so every Cloudflare build failed (Cannot find module '.../build.js'). GitHub Actions stayed green because it built a different way — nothing surfaced the failure.The live site is already fixed (Cloudflare build command repointed + a successful deploy). This PR makes the repo the durable source of truth so it can't drift again.
Changes
scripts/build.sh— single build recipe, pins mdBook 0.5.2 + mdbook-mermaid 0.17.0. Cloudflare Pages' build command is nowbash scripts/build.sh.rfc_deploy.yml— no longer pushes to the retiredgh-pagesbranch; now runsscripts/build.shon push+PR so CI goes red when the real build would fail. Bumpedcheckout@v2.3.1→v4.rfc_test.yml— builds via the same script, thenmdbook test. Single-sources the mdBook version.DEPLOYMENT.md— documents the real pipeline.Verify
CI here runs
scripts/build.shon Ubuntu — a green check is the build working exactly as Cloudflare runs it.