Skip to content

ci: Run zizmor on GitHub Actions and fix security findings #1370

Description

@vdemeester

Description

Run zizmor, a static analysis tool for GitHub Actions, on this repository's workflows to identify and fix security issues. Add zizmor as a CI check.

This follows the same work done in tektoncd/pipeline#9667.

What needs to be done

  1. Run zizmor --fix=all . to auto-fix findings:

    • Add persist-credentials: false to all actions/checkout steps (artipacked)
    • Fix template injection by replacing ${{ }} in run: blocks with shell env vars (template-injection)
  2. Add zizmor CI workflow (.github/workflows/zizmor.yaml) that runs on pushes to main and PRs, uploading SARIF results to GitHub Advanced Security

  3. Fix remaining non-auto-fixable findings manually:

  4. File follow-up issues for any remaining findings that require broader changes (e.g., secrets-outside-env, secrets-inherit)

Reference

/kind cleanup

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions