Repository navigation
fix(ci): remove kodata symlinks that break newer ko versions - #1815
Merged
vdemeester merged 1 commit intoJul 28, 2026
Merged
vdemeester merged 1 commit into
vdemeester merged 1 commit into
Conversation
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
tekton-robot
added
the
size/L
Member
|
/approve |
Member
|
/lgtm |
Member
|
/approve |
Member
Author
|
@wlynch @chitrangpatel Could you please add '/approve'? or @jkhelil we might have to force-merge this. |
Contributor
|
@vdemeester @afrittoli - Could you help merge this fix. This is blocking a few dependabot version upgrade PRs |
vdemeester
approved these changes
Jul 28, 2026
vdemeester
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jkhelil, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Cherry-pick of #1738 to
release-v0.20.x.Newer
koversions (v0.19+) reject symlinks inkodata/that resolveoutside the kodata root directory. The
release-v0.20.xbranch stillhad three such symlinks (
HEAD,refs,LICENSE), causing every PR'sE2E tests to fail during
ko apply.This fix was already applied to
main(#1738),release-v0.25.x(#1745), and
release-v0.27.x(#1744)cmd/controller/kodata/HEADsymlinkcmd/controller/kodata/refssymlinkcmd/controller/kodata/LICENSEsymlink with actual filekoto v0.18.1 in CI workflowSubmitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes