fix(nexus): do not pass on empty token for sync nexus calls#439
Merged
Conversation
chris-olszewski
changed the title
GregoryTravis
approved these changes
May 18, 2026
chris-olszewski
force-pushed
the
olszewski/fix_nexus_token
branch
from
2bcf88d to
b3c4fe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
""as an operation token to end users for sync nexus operations.test_nexus_operation_handle_async_has_tokenWhy?
nilis more idiomatic than""for missing valuetest_nexus_operation_handle_async_has_tokenflake in CI. This can happen if core receives a nexus completion from server before a start which will have core emit a[SyncStart, Complete]activation even if the operation is async. With the previous behavior of forwarding the empty operation token this would trigger the test to fail when we asserted that the length was non-zero. With theniltoken change this test would still fail, but earlier while it was waiting on a token to be populated.Checklist
Closes N/A
How was this tested:
Updated unit tests
Any docs updates needed?
N/A, our doccomments/types already call out that for sync ops this should be nil