Skip to content

Make build scripts exit when a command fails#589

Merged
teorth merged 2 commits into
teorth:mainfrom
PEliet:fix-build-scripts-fail-fast-from-main
Jul 17, 2026
Merged

Make build scripts exit when a command fails#589
teorth merged 2 commits into
teorth:mainfrom
PEliet:fix-build-scripts-fail-fast-from-main

Conversation

@PEliet

@PEliet PEliet commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Make build.sh exit when a normal command fails.
  • Apply the same failure handling to build-web.sh.
  • Correct the comments to describe both ordinary-command and pipeline failures.

set -o pipefail only changes how a pipeline reports failure; it does not stop a script after a standalone command fails. Adding set -e ensures a failure from commands such as lake exe cache get is propagated instead of allowing the script to continue.

Testing

  • Not run locally: this change only affects Bash startup options, and the current Windows environment has no usable Bash/WSL distribution.
  • Please rely on the repository's GitHub Actions build for full validation.

@teorth
teorth merged commit 2c7edf2 into teorth:main Jul 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants