Fix custom range controls dropping extended command arguments - #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve all custom-menu command arguments when updating range controls.
The range update path previously extracted only the channel and command ID, dropping additional command arguments such as a layer or item index.
For a control defined as:
changing its value to
7incorrectly sent:instead of:
Firmware expecting the extended argument could therefore update the wrong setting or interpret the value as an index.
Fix
Range SET commands now:
Tests
Added regression coverage confirming that:
Verification
npm testnpx tsc --noEmit