feat(auth): restrict GitHub login by organization - #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
GITHUB_OAUTH_ALLOWED_ORGANIZATIONconfiguration for direct GitHub authentication.organization_membership_required.Why
Self-hosted teams need to limit Facility login to one GitHub organization without reintroducing the WorkOS/OIDC broker. This keeps the current direct GitHub flow and makes the additional organization gate explicitly opt-in.
Verification
Focused provider/config tests: 17 passed, covering normalization, unset behavior, active membership, pending/non-member denial, malformed responses, and upstream failure.
Database-backed browser auth integration: 4 passed, including active-member success, non-member denial with no session, and unrestricted login when unset.
terraform -chdir=infra/terraform/aws validatereports the AWS configuration is valid.Rendered Docker Compose with
GITHUB_OAUTH_ALLOWED_ORGANIZATION=theamand confirmed the API container receives that exact value.Checked the implementation against the official GitHub endpoint contract for
GET /user/memberships/orgs/{org}and its Members (read) permission.pnpm verifypasses locallyBehaviour verified beyond the test suite (Terraform validation and rendered Docker Compose configuration)
Documentation updated, or no user-facing change