Repository navigation
Include RH subscription management in containerized - #5314
Conversation
|
The PR preview for a734251 is available at theforeman-foreman-documentation-preview-pr-5314.surge.sh The following output files are affected by this PR: |
| .Prerequisites | ||
| * The `foreman_rh_cloud` plugin is enabled on {ProjectServer}. | ||
| You can enable the plugin by running `{foreman-installer}`: | ||
| .Procedure |
There was a problem hiding this comment.
Making sure the steps in the procedure render correctly for all builds was tricky. The result that I'm proposing is:
- For Satellite builds, there is a single step procedure where the step is a number (
1.) rather than a bullet point (*). This is because eventually, the second step in the procedure will also get containerized and the number (1.) will be correct. So this divergence from style guidelines is only temporary and the alternative would be to use a lot of conditionals to turn that1.into*(IMO not worth it) - For containerized and non-containerized Katello builds, the procedure includes only the step for connected servers (because disconnected is not available in Katello builds).
- The disconnected step is actually not shown in either build right now; but I'd like to keep it in the source because we expect for it to be added eventually/soon (after the containerized solution becomes available).
|
Hi @jeremylenz, can you please review this update? |
4983dd4 to
70e31d5
Compare
jeremylenz
left a comment
There was a problem hiding this comment.
Checked 3 previews (index-satellite, index-katello, index-containerized-katello) and they all look correct. Tech ACK 👍
|
Thanks @jeremylenz! We'll also need a testing ack for this PR. Could you perhaps check whether the functionality described in the chapter is covered by automated tests for containerized deployments? Or feel free to use any other way to ensure this is tested based on your team's preference. |
| + | ||
| [options="nowrap" subs="+quotes,verbatim,attributes"] | ||
| ---- | ||
| # foreman-rake rh_cloud_inventory:report:generate |
There was a problem hiding this comment.
We will no longer recommend or allow generating inventory reports via foreman-rake. See theforeman/foremanctl#825
I think this will need to be replaced with API instructions, or ideally, a command added to Hammer that makes it easier.
There was a problem hiding this comment.
This can be done via web UI, no?
There was a problem hiding this comment.
actually, yes, web UI would be the most user-friendly!
There was a problem hiding this comment.
This is the part that is currently excluded for containerized because the functionality is not available in containerized deployments. When I last inquired about this particular foreman-rake task, I found out that not even the web UI counterpart would work in containerized. Has that changed? If not, I believe we can leave this excluded for containerized guides.
There was a problem hiding this comment.
@nofaralfasi After your PR merge, web UI download of the reports should work correctly, right?
There was a problem hiding this comment.
I think it's past feature freeze, is that right? Will theforeman/foremanctl#825 make it into 5.0?
There was a problem hiding this comment.
We can go past feature freeze for bugs. Depends how you look at it 😄
There was a problem hiding this comment.
This is blocking basic functionality, so I view it more as a bug
There was a problem hiding this comment.
Record keeping: theforeman/foremanctl#825 was closed in favor of theforeman/foreman_rh_cloud#1262. That has been merged so I'll try to make progress with this docs PR now.
|
Hi @jeremylenz, now that theforeman/foreman_rh_cloud#1262 has been merged, is it a good time for a final re-review of this documentation update? I'd like to know if the contents of 2. Managing Red Hat subscriptions are ready to be included in containerized deployments. Specifically the section Also, the documentation team is requesting explicit testing acks for including existing documentation in containerized deployments, see also #5314 (comment). Are the procedures included in |
Two things to think about here -- (1) the current state of behavior; and (2) what we want to support and document. (1) Currently, theforeman/foreman_rh_cloud#1262 is merged, but we have just this morning discovered another bug that breaks reporting. That bug will be fixed ASAP, but until then these instructions will not be in a testable state. (2) Ideally in the containerized world, we will shift from recommending foreman-rake tasks to recommending report generation via web UI. Once the issues above are worked out, the "disconnected" way to generate the report should be as simple as clicking Generate in the UI. (Also note that in a disconnected setup, you will have to perform some additional steps after generating your report to make sure that the data gets to Red Hat.) |
Thanks a lot for the comments @jeremylenz. This is the last chapter to be included in the Managing Content guide, it will be a relief when we're done here! 🙃
Do you have a link to the PR that fixes the bug?
Agreed, but when it comes to the 5.0 release (that's where we're cherry-picking this change), waiting for the bug fix in (1) should be enough, right? |
The additional steps I am referring to are basically Step 2-3 in this Red Hat doc: https://access.redhat.com/solutions/7133704 I think we meant to file an RFE to move that knowledge to the official docs, but it hasn't happened yet. |
The bug is https://redhat.atlassian.net/browse/SAT-52095 and there is no fix yet. cc @vkrizan |
|
Should I just go back to excluding section "2.1. Tracking subscription usage by using the Subscriptions service" from containerized completely, then? I'd really love to include whatever I can in the containerized docs. We can track "2.1. Tracking subscription usage by using the Subscriptions service" as a to-do item for the future. @jeremylenz |
|
@aneta-petrova That seems fine to me for now. 👍 |
Update tracking subscription usage to meet requirements on procedures Add a disclaimer about disconnected servers
This reverts commit f921087c069f5876cb2f8c542aab05c061f6deb1.
bc29ae1 to
e38b88c
Compare
|
Hi @jeremylenz, can you please re-review? With the latest set of changes, this PR adds chapter Does the current set of changes make the EDIT: I also raised https://redhat.atlassian.net/browse/SAT-52316 to track the (future) addition of |
jeremylenz
left a comment
There was a problem hiding this comment.
LGTM, thanks @aneta-petrova!
(cherry picked from commit 2ab27a1)
What changes are you introducing?
Adding assembly on RH subscription management to containerized guides
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
To extend the containerized docs set
https://redhat.atlassian.net/browse/SAT-47721
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Contributor checklists
Please cherry-pick my commits into: