Repository navigation
Fixes #39717 - Prepare for the upcoming remediation changes - #178
Open
michalgritzbach wants to merge 1 commit into
Open
michalgritzbach wants to merge 1 commit into
michalgritzbach wants to merge 1 commit into
Conversation
michalgritzbach
force-pushed
the
39717-remediation-command-changes
branch
from
August 31, 2026 14:02
2cc1ef0 to
8ce7449
Compare
|
@michalgritzbach seems good to me. I could not went through the whole code in details due to limited time now (I haven't seen ruby for 10+ years so I am slow) but so far the solution seems to do what I would expect based on the code. |
ofedoren
reviewed
Sep 3, 2026
adamruzicka
reviewed
Sep 14, 2026
adamruzicka
left a comment
adamruzicka
left a comment
Contributor
There was a problem hiding this comment.
I like the general approach, left some minor comments inline
| # Unknown versions are treated as old leapp, so that reports collected | ||
| # before the version was recorded keep rendering the way they used to. | ||
| def quoted_by_leapp?(leapp_version) | ||
| version = Gem::Version.new(leapp_version.to_s[/\A[0-9][0-9.]*/].to_s.chomp('.')) |
Contributor
There was a problem hiding this comment.
This would mean parsing the version over and over again for every preupgrade report entry. Could we do it just per remediation report?
Contributor
There was a problem hiding this comment.
That's not quite it, is it? It now lives in RemediationPlan.build, but that is still called separately for each entry of the preupgrade report
michalgritzbach
force-pushed
the
39717-remediation-command-changes
branch
from
September 14, 2026 09:02
8ce7449 to
ab411b1
Compare
michalgritzbach
force-pushed
the
39717-remediation-command-changes
branch
from
September 29, 2026 10:12
ab411b1 to
6558b79
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure that preupgrade report entries are prepared for remediation quotation changes that landed in leapp 0.22.0 (oamg/leapp-repository#1520).