Repository navigation
Fixes #39752 - Remove leapp preupgrade report from legacy implementation in the leapp plugin - #179
Merged
Merged
Conversation
MariaAga
requested changes
Sep 10, 2026
MariaAga
left a comment
Member
There was a problem hiding this comment.
AI findings of a few remaining files that can be deleted:
- webpack/csrf.js — sole consumer was the deleted PreupgradeReports/index.js. Zero references left.
- (not a 100% sure a bout this one, please check before deleting)
The whole non-API controller stack:app/controllers/preupgrade_reports_controller.rb,resources :preupgrade_reports, only:%i[index](config/routes.rb:4),app/views/preupgrade_reports/{index,show}.json.rabl,app/views/preupgrade_report_entries/base.json.rabl,test/functional/preupgrade_reports_controller_test.rb.
Only caller waspreupgrade_reports_path(...)in the deleted partial. If dropped, also remove:preupgrade_reports => %i[index show job_invocation]fromengine.rb:27(it already listed show/job_invocation, which that controller never had). jest.config.jsSVG transform + thejest-svg-transformerdevDependency — the only .svg imports lived in the deletedPreupgradeReportsList/components/helpers.js; none remain.
Contributor
Author
|
@MariaAga thank you, I deleted the files you mentioned except for the API controllers, because they are still used by |
Contributor
|
@kmalyjur Bugs are merged so this PR is unblocked. Please rebase |
Lukshio
reviewed
Oct 5, 2026
kmalyjur
force-pushed
the
remove-legacy-leapp
branch
from
October 7, 2026 09:13
9870677 to
25147c4
Compare
Contributor
|
Packit tested, #183 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
webpack/components/PreupgradeReports,webpack/components/PreupgradeReportsListand all related files.CANNOT BE MERGED YET, #183 is blocking it.