Skip to content

Fixes #39752 - Remove leapp preupgrade report from legacy implementation in the leapp plugin - #179

Merged
Lukshio merged 3 commits into
theforeman:masterfrom
kmalyjur:remove-legacy-leapp
Oct 8, 2026
Merged

Lukshio merged 3 commits into
theforeman:masterfrom
kmalyjur:remove-legacy-leapp

Conversation

@kmalyjur

@kmalyjur kmalyjur commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Removed webpack/components/PreupgradeReports, webpack/components/PreupgradeReportsList and all related files.

CANNOT BE MERGED YET, #183 is blocking it.

@MariaAga MariaAga self-assigned this Sep 9, 2026

@MariaAga MariaAga left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI findings of a few remaining files that can be deleted:

  • webpack/csrf.js — sole consumer was the deleted PreupgradeReports/index.js. Zero references left.
  • (not a 100% sure a bout this one, please check before deleting)
    The whole non-API controller stack: app/controllers/preupgrade_reports_controller.rb, resources :preupgrade_reports, only: %i[index] (config/routes.rb:4), app/views/preupgrade_reports/{index,show}.json.rabl, app/views/preupgrade_report_entries/base.json.rabl, test/functional/preupgrade_reports_controller_test.rb.
    Only caller was preupgrade_reports_path(...) in the deleted partial. If dropped, also remove :preupgrade_reports => %i[index show job_invocation] from engine.rb:27 (it already listed show/job_invocation, which that controller never had).
  • jest.config.js SVG transform + the jest-svg-transformer devDependency — the only .svg imports lived in the deleted PreupgradeReportsList/components/helpers.js; none remain.

@kmalyjur

Copy link
Copy Markdown
Contributor Author

@MariaAga thank you, I deleted the files you mentioned except for the API controllers, because they are still used by PreupgradeReportsTable.

@Lukshio

Lukshio commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

@kmalyjur Bugs are merged so this PR is unblocked. Please rebase

Comment thread webpack/reducer.js Outdated
@Lukshio Lukshio self-assigned this Oct 5, 2026
@kmalyjur
kmalyjur force-pushed the remove-legacy-leapp branch from 9870677 to 25147c4 Compare October 7, 2026 09:13
@Lukshio

Lukshio commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Packit tested, #183 is merged

@Lukshio
Lukshio merged commit 2e653fb into theforeman:master Oct 8, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants