Repository navigation
Fixes #39793 - Remove allow_multiple_content_views setting setup from tests - #1260
Merged
nofaralfasi merged 2 commits intoSep 29, 2026
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
… tests Drop UpstreamOnlySettingsTestHelper calls for the removed Katello setting. Co-authored-by: Cursor <cursoragent@cursor.com>
jnagare-redhat
force-pushed
the
remove-allow-multiple-content-views
branch
from
September 23, 2026 14:15
57ef48e to
51f01d8
Compare
nofaralfasi
reviewed
Sep 29, 2026
nofaralfasi
left a comment
nofaralfasi
left a comment
Contributor
There was a problem hiding this comment.
Approve with one nit: delete the now-unused UpstreamOnlySettingsTestHelper module from test/test_plugin_helper.rb (lines 141–147). These 3 removed calls were its only usages.
Merge this PR promptly to unblock Katello #11875's CI.
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
Updated |
nofaralfasi
approved these changes
Sep 29, 2026
chris1984
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
UpstreamOnlySettingsTestHelper.set_if_available('allow_multiple_content_views')from tests that referenced the Katello setting, which is being removed in the companion Katello change (Fixes #39793).Considerations taken when implementing this change?
allow_multiple_content_views.What are the testing steps for this pull request?
tags_generator_test.rbpasses.cloud_request_forwarder_test.rbpasses.machine_telemetries_controller_test.rbpasses.Made with Cursor